allow vitest to override invalid Wrangler assets config#9227
Merged
petebacondarwin merged 3 commits intomainfrom May 16, 2025
Merged
allow vitest to override invalid Wrangler assets config#9227petebacondarwin merged 3 commits intomainfrom
petebacondarwin merged 3 commits intomainfrom
Conversation
petebacondarwin
commented
May 13, 2025
Contributor
Author
There was a problem hiding this comment.
This change is in its own commit, and just removes warnings from the build of the vitest-pool-workers
petebacondarwin
commented
May 13, 2025
Contributor
Author
There was a problem hiding this comment.
This is the crux of the fix, we pass in the assets configuration from the vitest config as an override.
Contributor
|
A Wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15051123524/npm-package-wrangler-9227Prereleases for other packages:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15051123524/npm-package-cloudflare-workers-bindings-extension-9227 -O ./cloudflare-workers-bindings-extension.0.0.0-v596934982.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v596934982.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15051123524/npm-package-create-cloudflare-9227 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15051123524/npm-package-cloudflare-kv-asset-handler-9227
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15051123524/npm-package-miniflare-9227
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15051123524/npm-package-cloudflare-pages-shared-9227
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15051123524/npm-package-cloudflare-unenv-preset-9227
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15051123524/npm-package-cloudflare-vite-plugin-9227
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15051123524/npm-package-cloudflare-vitest-pool-workers-9227
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15051123524/npm-package-cloudflare-workers-editor-shared-9227
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15051123524/npm-package-cloudflare-workers-shared-9227
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15051123524/npm-package-cloudflare-workflows-shared-9227Note that these links will no longer work once the GitHub Actions artifact expires. |
🦋 Changeset detectedLatest commit: d8a9ee7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
765058a to
593dc45
Compare
emily-shen
reviewed
May 15, 2025
Without this change you would see the following when building:
```
▲ [WARNING] The condition "types" here will never be used as it comes after both "import" and "require" [package.json]
package.json:36:3:
36 │ "types": "./dist/config/index.d.ts"
╵ ~~~~~~~
The "import" condition comes earlier and will be used for all "import" statements:
package.json:34:3:
34 │ "import": "./dist/config/index.cjs",
╵ ~~~~~~~~
The "require" condition comes earlier and will be used for all "require" calls:
package.json:35:3:
35 │ "require": "./dist/config/index.cjs",
```
…wrangler assets options
…erride wrangler assets options
593dc45 to
d8a9ee7
Compare
petebacondarwin
commented
May 16, 2025
Comment on lines
+8
to
+11
| "test": "vitest --config vitest.workers.config.ts", | ||
| "test:ci": "run-script-os", | ||
| "test:ci:default": "vitest run --config vitest.workers.config.ts --reporter basic", | ||
| "test:ci:win32": "vitest run --config vitest.workers.config.ts --reporter basic --exclude test/sqlite-in-do.test.ts" | ||
| "test:ci:default": "vitest run --config vitest.workers.config.ts", | ||
| "test:ci:win32": "vitest run --config vitest.workers.config.ts --exclude test/sqlite-in-do.test.ts" |
Contributor
Author
There was a problem hiding this comment.
Removed --reporter basic because it is deprecated and has no effect.
emily-shen
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9130