Conversation
🦋 Changeset detectedLatest commit: 6b15d37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-wrangler-8130You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8130/npm-package-wrangler-8130Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-wrangler-8130 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-cloudflare-workers-bindings-extension-8130 -O ./cloudflare-workers-bindings-extension.0.0.0-va9489be6e.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va9489be6e.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-create-cloudflare-8130 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-cloudflare-kv-asset-handler-8130miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-miniflare-8130@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-cloudflare-pages-shared-8130@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-cloudflare-unenv-preset-8130@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-cloudflare-vite-plugin-8130@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-cloudflare-vitest-pool-workers-8130@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-cloudflare-workers-editor-shared-8130@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-cloudflare-workers-shared-8130@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13313097367/npm-package-cloudflare-workflows-shared-8130Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
| } else if ( | ||
| typeof value === "string" && | ||
| !(allowedValuesForArg === "*" || allowedValuesForArg.includes(value)) | ||
| ) { | ||
| result[key] = "<REDACTED>"; | ||
| } else if (Array.isArray(value)) { | ||
| result[key] = value.map((v) => | ||
| typeof v === "string" ? "<REDACTED>" : v | ||
| typeof v === "string" && | ||
| !(allowedValuesForArg === "*" || allowedValuesForArg.includes(v)) | ||
| ? "<REDACTED>" | ||
| : v |
There was a problem hiding this comment.
Could you add some comments explaining this logic? It's gotten pretty hairy—but be nice if there was a way to simplify
There was a problem hiding this comment.
yeah i'd like to tidy all of this up, because the sanitise + redact + normalise functions have gotten very redundant and messy. Would you be okay with leaving it for now so I can start collecting metrics, and doing that in a fast follow this afternooon?
There was a problem hiding this comment.
depends how long until the release really 😅
There was a problem hiding this comment.
Sounds good--let's get this in as-is for the current release
1b695f3 to
6b15d37
Compare
Include default values for wrangler types --path and --x-include-runtime in telemetry
User provided strings are still left redacted as always.
Note i've also tested this manually for wrangler types