feat: Add a queues update subcommand by sdnts · Pull Request #8120 · cloudflare/workers-sdk

sdnts · 2025-02-12T19:52:31Z

Fixes MQ-667

Adds a new queues update subcommand that lets you update a Queue after it is created

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because:
Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because: I've validated these changes manually
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s): [Queues] Fix max retention period limit cloudflare-docs#17194 (review)
- Documentation not necessary because:

changeset-bot · 2025-02-12T19:52:35Z

🦋 Changeset detected

Latest commit: e9ec46a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Minor
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/wrangler/src/queues/cli/commands/update.ts

github-actions · 2025-02-12T21:00:48Z

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-wrangler-8120

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8120/npm-package-wrangler-8120

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-wrangler-8120 dev path/to/script.js

Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-cloudflare-workers-bindings-extension-8120 -O ./cloudflare-workers-bindings-extension.0.0.0-va592fe709.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va592fe709.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-create-cloudflare-8120 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-cloudflare-kv-asset-handler-8120

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-miniflare-8120

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-cloudflare-pages-shared-8120

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-cloudflare-unenv-preset-8120

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-cloudflare-vite-plugin-8120

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-cloudflare-vitest-pool-workers-8120

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-cloudflare-workers-editor-shared-8120

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-cloudflare-workers-shared-8120

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13309141735/npm-package-cloudflare-workflows-shared-8120

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@3.108.1 includes the following runtime dependencies:

Package	Constraint	Resolved
`miniflare`	workspace:*	3.20250204.0
`workerd`	1.20250204.0	1.20250204.0
`workerd --version`	1.20250204.0	2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

packages/wrangler/src/__tests__/queues.test.ts

.changeset/early-melons-deny.md

.changeset/gentle-tables-guess.md

penalosa · 2025-02-13T12:57:49Z

packages/wrangler/src/__tests__/queues.test.ts

+				if (queueSettings?.delivery_delay === undefined) {
+					queueSettings.delivery_delay = 0;
+				}
+				if (queueSettings?.message_retention_period === undefined) {
+					queueSettings.message_retention_period = 345600;
+				}


(non blocking) These can be defaults on the function definition

I'll do this with the createCommand() helper change?

packages/wrangler/src/queues/cli/commands/index.ts

…ng a queue

holopin-bot · 2025-02-13T14:57:51Z

Congratulations @sdnts, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm73gs4n223560cl4bdzmhbjr

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

sdnts requested a review from a team as a code owner February 12, 2025 19:52

sdnts mentioned this pull request Feb 12, 2025

[DO NOT MERGE] MQ-667: add queues update sub command #6450

Closed

12 tasks

maheshwarip reviewed Feb 12, 2025

View reviewed changes

packages/wrangler/src/queues/cli/commands/update.ts Show resolved Hide resolved

sdnts force-pushed the main branch from 7199092 to e149a0c Compare February 12, 2025 20:03

maheshwarip approved these changes Feb 12, 2025

View reviewed changes

sdnts force-pushed the main branch from 191a89b to 21f1482 Compare February 12, 2025 21:24

maheshwarip reviewed Feb 12, 2025

View reviewed changes

packages/wrangler/src/__tests__/queues.test.ts Show resolved Hide resolved

sdnts force-pushed the main branch from 5df309f to f79d6d5 Compare February 13, 2025 12:52

penalosa approved these changes Feb 13, 2025

View reviewed changes

sdnts force-pushed the main branch from b6265b7 to c850282 Compare February 13, 2025 13:07

sdnts requested a review from a team February 13, 2025 13:07

sdnts requested a review from a team as a code owner February 13, 2025 13:07

TaraGarg and others added 4 commits February 13, 2025 08:47

improve(wrangler): bounds checking for when setting queue delivery delay

90ad331

feat(wrangler): allow overriding message retention period when creati…

e5874bc

…ng a queue

feat(wrangler): add a new queues update command

6acf1f4

chore(wrangler): queues test updates for default values

e72d056

sdnts force-pushed the main branch from 3a5854f to e72d056 Compare February 13, 2025 13:47

Merge branch 'main' into main

e9ec46a

penalosa merged commit 3fb801f into cloudflare:main Feb 13, 2025
24 checks passed

workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Feb 13, 2025

workers-devprod mentioned this pull request Feb 13, 2025

Version Packages #8107

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add a queues update subcommand#8120

feat: Add a queues update subcommand#8120
penalosa merged 5 commits intocloudflare:mainfrom
sdnts:main

sdnts commented Feb 12, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

penalosa Feb 13, 2025 •

edited

Loading

Uh oh!

sdnts Feb 13, 2025

Uh oh!

Uh oh!

Uh oh!

holopin-bot bot commented Feb 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

sdnts commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

github-actions bot commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

penalosa Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdnts Feb 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

holopin-bot bot commented Feb 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

sdnts commented Feb 12, 2025 •

edited

Loading

changeset-bot bot commented Feb 12, 2025 •

edited

Loading

github-actions bot commented Feb 12, 2025 •

edited

Loading

penalosa Feb 13, 2025 •

edited

Loading