fix: hide wrangler banner in secret list --format=json#8103
Conversation
🦋 Changeset detectedLatest commit: c15e52e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| }, | ||
| }, | ||
| behaviour: { | ||
| printBanner: false, |
There was a problem hiding this comment.
printBanner can be a function that decides whether to print based on the args— printBanner: (args) => args.format === "pretty",
Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>
| import { getLegacyScriptName } from "../utils/getLegacyScriptName"; | ||
| import { isLegacyEnv } from "../utils/isLegacyEnv"; | ||
| import { readFromStdin, trimTrailingWhitespace } from "../utils/std"; | ||
| import { printWranglerBanner } from "../wrangler-banner"; |
| expect(std.out).toMatchInlineSnapshot(` | ||
| "Secret Name: the-secret-name | ||
| " | ||
| `); |
There was a problem hiding this comment.
This doesn't seem to be showing the banner?
| }, | ||
| }, | ||
| behaviour: { | ||
| printBanner: (args) => args.format === "pretty", |
There was a problem hiding this comment.
I guess you didn't want to go with args.format !== "json"?
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-wrangler-8103You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8103/npm-package-wrangler-8103Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-wrangler-8103 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-workers-bindings-extension-8103 -O ./cloudflare-workers-bindings-extension.0.0.0-vb012923a4.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vb012923a4.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-create-cloudflare-8103 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-kv-asset-handler-8103miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-miniflare-8103@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-pages-shared-8103@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-unenv-preset-8103@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-vite-plugin-8103@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-vitest-pool-workers-8103@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-workers-editor-shared-8103@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-workers-shared-8103@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13272703975/npm-package-cloudflare-workflows-shared-8103Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
|
For posterity—this does not affect C3, so merging without C3 tests fully finished |
Fixes #8101