feat: add some logging when no bindings are found#8028
Conversation
🦋 Changeset detectedLatest commit: 7a08454 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-wrangler-8028You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8028/npm-package-wrangler-8028Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-wrangler-8028 dev path/to/script.jsAdditional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-cloudflare-workers-bindings-extension-8028 -O ./cloudflare-workers-bindings-extension.0.0.0-v840abd1cf.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v840abd1cf.vsixcreate-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-create-cloudflare-8028 --no-auto-update@cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-cloudflare-kv-asset-handler-8028miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-miniflare-8028@cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-cloudflare-pages-shared-8028@cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-cloudflare-unenv-preset-8028@cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-cloudflare-vite-plugin-8028@cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-cloudflare-vitest-pool-workers-8028@cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-cloudflare-workers-editor-shared-8028@cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-cloudflare-workers-shared-8028@cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13156229495/npm-package-cloudflare-workflows-shared-8028Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
andyjessop
left a comment
There was a problem hiding this comment.
Lovely change, thanks 👍
|
Could we revisit this? It shows up for most default projects, and it feels like a bug everytime I see it. Happy to send a PR. |
Fixes DEVX-1588 (sort of).
The reported issue in the ticket (--dry-run not printing bindings) was not a wrangler issue in the end. However, to prevent similar situations happening again, it would be nice to explicitly log something out when there are no bindings found, in case bindings were expected.