Skip to content

Wranger dev support with serve_directly#7445

Merged
WillTaylorDev merged 1 commit into
mainfrom
willtaylor/wc-3000-e2e-tests
Dec 5, 2024
Merged

Wranger dev support with serve_directly#7445
WillTaylorDev merged 1 commit into
mainfrom
willtaylor/wc-3000-e2e-tests

Conversation

@WillTaylorDev

@WillTaylorDev WillTaylorDev commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

Add support in wrangler dev for invoking user worker ahead of assets via experimental_serve_directly = false. Additionally adds several unit, integration, and e2e tests for serve_directly behavior.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: n/a

@changeset-bot

changeset-bot Bot commented Dec 4, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c3a8690

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudflare/workers-shared Minor
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WillTaylorDev WillTaylorDev added the ci:e2e Run wrangler + vite-plugin E2E tests on a pull request label Dec 4, 2024
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-3000-e2e-tests branch 2 times, most recently from 6adc21c to c82e607 Compare December 4, 2024 21:09
@github-actions

github-actions Bot commented Dec 4, 2024

Copy link
Copy Markdown
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12180910165/npm-package-wrangler-7445

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7445/npm-package-wrangler-7445

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12180910165/npm-package-wrangler-7445 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12180910165/npm-package-create-cloudflare-7445 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12180910165/npm-package-cloudflare-kv-asset-handler-7445
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12180910165/npm-package-miniflare-7445
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12180910165/npm-package-cloudflare-pages-shared-7445
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12180910165/npm-package-cloudflare-vitest-pool-workers-7445
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12180910165/npm-package-cloudflare-workers-editor-shared-7445
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12180910165/npm-package-cloudflare-workers-shared-7445
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12180910165/npm-package-cloudflare-workflows-shared-7445

Note that these links will no longer work once the GitHub Actions artifact expires.


wrangler@3.92.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.2
workerd 1.20241106.2 1.20241106.2
workerd --version 1.20241106.2 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-3000-e2e-tests branch 2 times, most recently from 0d7a130 to 74d7837 Compare December 4, 2024 21:44
@WillTaylorDev WillTaylorDev marked this pull request as ready for review December 4, 2024 22:19
@WillTaylorDev WillTaylorDev requested review from a team as code owners December 4, 2024 22:19
Comment thread packages/wrangler/src/deploy/deploy.ts Outdated
Comment thread .changeset/strong-kings-visit.md Outdated
Comment thread packages/workers-shared/router-worker/tests/index.test.ts Outdated
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-3000-e2e-tests branch from 74d7837 to ed36f6a Compare December 5, 2024 01:29
Comment thread packages/wrangler/src/deploy/deploy.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: routing config should be removed

@CarmenPopoviciu

CarmenPopoviciu commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

much awesomeness @WillTaylorDev ♥️ . Thank you so much for working on this 🚀

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/wc-3000-e2e-tests branch from ed36f6a to c3a8690 Compare December 5, 2024 13:39
@WillTaylorDev WillTaylorDev merged commit f4ae6ee into main Dec 5, 2024
@WillTaylorDev WillTaylorDev deleted the willtaylor/wc-3000-e2e-tests branch December 5, 2024 14:57
@workers-devprod workers-devprod mentioned this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:e2e Run wrangler + vite-plugin E2E tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants