[miniflare]: Fix local `scheduled` handler returning exception when `assets` is enabled by ktKongTong · Pull Request #14177 · cloudflare/workers-sdk

ktKongTong · 2026-06-04T09:00:06Z

Fixes #9882

bypass asset rpc worker for scheduled handler

Relate: #13704

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: bug fix

A picture of a cute animal (not mandatory, but encouraged)

changeset-bot · 2026-06-04T09:00:11Z

🦋 Changeset detected

Latest commit: bed00e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
miniflare	Patch
@cloudflare/pages-shared	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch
wrangler	Patch
@cloudflare/wrangler-bundler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

workers-devprod · 2026-06-04T09:00:47Z

Codeowners approval required for this PR:

✅ @cloudflare/wrangler

Show detailed file reviewers

petebacondarwin

Is a simpler fix for this just to add the following to packages/miniflare/src/workers/assets/rpc-proxy.worker.ts

	scheduled(controller, env, ctx) {
		return this.env.USER_WORKER.scheduled(controller, env, ctx);
	}

Edit: It was not quite as easy as this but I think this is the right direction. Pushed a commit

…sets (cloudflare#9882)

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

petebacondarwin · 2026-06-05T15:46:32Z

I hope you don't mind but I have pushed a commit that is an alternative way to fix this.
Let me know what you think.

petebacondarwin · 2026-06-05T15:48:40Z

What I changed

Instead of bypassing the assets RPC proxy with a new SERVICE_RAW_USER_FALLBACK binding, I made the proxy itself forward scheduled events correctly. Two small pieces:

Added the service_binding_extra_handlers compatibility flag to the assets RPC proxy worker (packages/miniflare/src/plugins/assets/index.ts). Without this flag, calling this.env.USER_WORKER.scheduled() from inside the proxy is routed through JsRpc instead of the Fetcher.scheduled() built-in, which is what was producing outcome: "exception" (the user worker's scheduled handler was being called as a plain RPC method, so controller.noRetry() threw because the "controller" was just {cron, scheduledTime}). The entry worker already uses this flag.
Added a scheduled method to RPCProxyWorker that:
- Converts the inner ScheduledController into the { scheduledTime: Date, cron: string } shape expected by Fetcher.scheduled.
- Propagates the user worker's noRetry() decision onto the proxy's own controller (otherwise it stays at the default false).
- Re-throws when the inner outcome isn't "ok" so outcome: "exception" surfaces correctly through the proxy instead of being silently swallowed.

This let me revert the SERVICE_RAW_USER_FALLBACK binding, the new CoreBindings entry, and the entry-worker change — the dispatch flow stays unified through the proxy, which felt closer to the existing fetch/tail pattern in rpc-proxy.worker.ts.

All the tests you added still pass with this approach.

pkg-pr-new · 2026-06-05T15:56:21Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14177

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14177

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14177

miniflare

npm i https://pkg.pr.new/miniflare@14177

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14177

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14177

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14177

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14177

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14177

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14177

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14177

wrangler

npm i https://pkg.pr.new/wrangler@14177

@cloudflare/wrangler-bundler

npm i https://pkg.pr.new/@cloudflare/wrangler-bundler@14177

commit: bed00e4

workers-devprod

Codeowners reviews satisfied

ktKongTong · 2026-06-06T02:50:00Z

Added the service_binding_extra_handlers compatibility flag to the assets RPC proxy worker (packages/miniflare/src/plugins/assets/index.ts). Without this flag, calling this.env.USER_WORKER.scheduled() from inside the proxy is routed through JsRpc instead of the Fetcher.scheduled() built-in, which is what was producing outcome: "exception" (the user worker's scheduled handler was being called as a plain RPC method, so controller.noRetry() threw because the "controller" was just {cron, scheduledTime}). The entry worker already uses this flag.

Thanks for pushing the update. I wasn’t aware of the service_binding_extra_handlers flag. This approach is much better.

petebacondarwin

Let's go!

ktKongTong requested a review from workers-devprod as a code owner June 4, 2026 09:00

workers-devprod requested review from a team and penalosa and removed request for a team June 4, 2026 09:00

This comment was marked as resolved.

Sign in to view

ktKongTong mentioned this pull request Jun 4, 2026

fix(miniflare): Fix local scheduled handler returning exception when assets is enabled #13704

Closed

5 tasks

This comment was marked as resolved.

Sign in to view

petebacondarwin requested changes Jun 5, 2026

View reviewed changes

petebacondarwin requested review from petebacondarwin and removed request for penalosa June 5, 2026 11:39

ktKongTong and others added 4 commits June 5, 2026 16:31

fix(miniflare): Fix local scheduled handler dispatch for Workers + As…

1f77523

…sets (cloudflare#9882)

chore: update changeset

f7c9c2d

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

chore: update CoreBindings string prefix to MINIFLARE_*

fd6bdd1

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

simplify the fix

eb52f34

petebacondarwin force-pushed the asset-scheduled branch from fdfa954 to eb52f34 Compare June 5, 2026 15:45

workers-devprod added this to workers-sdk Jun 5, 2026

github-project-automation Bot moved this to In Review in workers-sdk Jun 5, 2026

NuroDev approved these changes Jun 5, 2026

View reviewed changes

Comment thread packages/miniflare/test/index.spec.ts

workers-devprod approved these changes Jun 5, 2026

View reviewed changes

ktKongTong added 2 commits June 6, 2026 10:30

test: assert asset content-type header

1ad6a9a

test: assert asset content-type header

baeadd3

ktKongTong changed the title ~~fix(miniflare): bypass assets' rpc proxy worker for scheduled handler~~ [miniflare]: Fix local scheduled handler returning exception when assets is enabled Jun 6, 2026

chore: lint code

bed00e4

petebacondarwin approved these changes Jun 6, 2026

View reviewed changes

github-project-automation Bot moved this from In Review to Approved in workers-sdk Jun 6, 2026

petebacondarwin merged commit 48c4ff0 into cloudflare:main Jun 6, 2026
52 checks passed

github-project-automation Bot moved this from Approved to Done in workers-sdk Jun 6, 2026

workers-devprod mentioned this pull request Jun 6, 2026

Version Packages #14179

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[miniflare]: Fix local `scheduled` handler returning exception when `assets` is enabled#14177

[miniflare]: Fix local `scheduled` handler returning exception when `assets` is enabled#14177
petebacondarwin merged 7 commits into
cloudflare:mainfrom
ktKongTong:asset-scheduled

ktKongTong commented Jun 4, 2026 •

edited by petebacondarwin

Loading

Uh oh!

changeset-bot Bot commented Jun 4, 2026 •

edited

Loading

Uh oh!

workers-devprod commented Jun 4, 2026 •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

petebacondarwin left a comment •

edited

Loading

Uh oh!

petebacondarwin commented Jun 5, 2026

Uh oh!

petebacondarwin commented Jun 5, 2026

Uh oh!

pkg-pr-new Bot commented Jun 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

workers-devprod left a comment

Uh oh!

ktKongTong commented Jun 6, 2026

Uh oh!

petebacondarwin left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ktKongTong commented Jun 4, 2026 • edited by petebacondarwin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

workers-devprod commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

petebacondarwin left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petebacondarwin commented Jun 5, 2026

Uh oh!

petebacondarwin commented Jun 5, 2026

Uh oh!

pkg-pr-new Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

workers-devprod left a comment

Choose a reason for hiding this comment

Uh oh!

ktKongTong commented Jun 6, 2026

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ktKongTong commented Jun 4, 2026 •

edited by petebacondarwin

Loading

changeset-bot Bot commented Jun 4, 2026 •

edited

Loading

workers-devprod commented Jun 4, 2026 •

edited

Loading

petebacondarwin left a comment •

edited

Loading

pkg-pr-new Bot commented Jun 5, 2026 •

edited

Loading