fix(miniflare): materialize local explorer UI for PnP#13767
Conversation
🦋 Changeset detectedLatest commit: ab95248 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✅ All changesets look good |
|
Both are properly exported. The implementation looks solid. Let me do a final check on whether there are any issues I might have missed:
The PR is clean. The approach is well-reasoned (stage + atomic rename, manual copy for PnP compatibility), the error handling is correct, and the test covers the key behavior. LGTM |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
I have tested that this works in the original repo which triggered the report and repro, and it also works in a half dozen others as well. |
89f2f3f to
ab95248
Compare
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Fixes #13749.
A picture of a cute animal (not mandatory, but encouraged)