Skip to content

fix(miniflare): materialize local explorer UI for PnP#13767

Merged
edmundhung merged 4 commits into
mainfrom
edmundhung/fix-local-explorer-pnp
May 5, 2026
Merged

fix(miniflare): materialize local explorer UI for PnP#13767
edmundhung merged 4 commits into
mainfrom
edmundhung/fix-local-explorer-pnp

Conversation

@edmundhung

@edmundhung edmundhung commented May 1, 2026

Copy link
Copy Markdown
Member

Fixes #13749.


  • Tests
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

A picture of a cute animal (not mandatory, but encouraged)

@changeset-bot

changeset-bot Bot commented May 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ab95248

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@edmundhung edmundhung changed the title Edmundhung/fix local explorer pnp fix(miniflare): materialize local explorer UI for PnP May 1, 2026
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk May 1, 2026
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@ask-bonk

ask-bonk Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

Both are properly exported. The implementation looks solid. Let me do a final check on whether there are any issues I might have missed:

  1. Logic: The stage-and-rename pattern is a well-known atomic directory deployment technique.
  2. Error handling: The catch block correctly cleans up the staging directory.
  3. copyDirectorySync: Uses readdirSync/statSync/readFileSync which work through Yarn PnP hooks, unlike cpSync.
  4. Test: Properly uses { expect } from test context, validates both the service configuration and that files actually exist on disk.
  5. Cleanup: The #tmpPath is cleaned up on Miniflare dispose, which will remove the materialized explorer UI.
  6. Changeset: Correctly scoped to miniflare as a patch.

The PR is clean. The approach is well-reasoned (stage + atomic rename, manual copy for PnP compatibility), the error handling is correct, and the test covers the key behavior.

LGTM

github run

@pkg-pr-new

pkg-pr-new Bot commented May 1, 2026

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13767

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13767

miniflare

npm i https://pkg.pr.new/miniflare@13767

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13767

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13767

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13767

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13767

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13767

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@13767

wrangler

npm i https://pkg.pr.new/wrangler@13767

commit: ab95248

@edmundhung edmundhung marked this pull request as ready for review May 1, 2026 12:42
@workers-devprod workers-devprod requested review from a team and emily-shen and removed request for a team May 1, 2026 12:42
@workers-devprod

workers-devprod commented May 1, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

Comment thread packages/miniflare/src/plugins/core/index.ts Outdated
@NormalGaussian

Copy link
Copy Markdown

I have tested that this works in the original repo which triggered the report and repro, and it also works in a half dozen others as well.

Comment thread packages/miniflare/src/plugins/core/index.ts

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@edmundhung edmundhung force-pushed the edmundhung/fix-local-explorer-pnp branch from 89f2f3f to ab95248 Compare May 5, 2026 10:45

@emily-shen emily-shen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk May 5, 2026
@edmundhung edmundhung merged commit 12fb5db into main May 5, 2026
59 checks passed
@edmundhung edmundhung deleted the edmundhung/fix-local-explorer-pnp branch May 5, 2026 12:41
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[miniflare] Local explorer disk service incompatible with Yarn PnP

4 participants