[cli] Update @clack/core and @clack/prompts to v1.2.0#13644
Conversation
Bumps the Clack dependencies used by @cloudflare/cli (consumed internally by wrangler, miniflare, and create-cloudflare) from 0.x to 1.2.0. Clack 1.0 is ESM-only and renames TextPrompt#valueWithCursor to userInputWithCursor; internal call sites are updated to match. Validator return types have been widened to accept Error instances alongside strings, matching Clack's new API. Addresses #12933 (comment)
🦋 Changeset detectedLatest commit: 0ef275f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Changeset ReviewSummary✅ All changesets look good Review Detailsupdate-clack-to-v1.md
vite-plugin-cf-registry-support.md
ninety-doors-sit.md
sour-bears-shake.md
vitest-pool-workers-reset-helper.md
stream-local-video-serving.md
dependabot-update-13633.md
fix-vite-config-denylist.md
sour-paws-thank.md
dependabot-update-13645.md
detect-waf-block-response.md
angry-bears-count.md
fix-nonretryable-error-message.md
ai-search-inherit-display.md
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
|
Now I have a complete picture. Let me assess whether there are any actionable issues:
I don't see any logic bugs, security issues, backward compatibility violations, or incorrect API behavior. All the changes are mechanically correct and properly aligned with the upstream LGTM |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Co-authored-by: Ben <4991309+NuroDev@users.noreply.github.com>
Addresses this comment.
Updates the Clack dependencies used by
@cloudflare/clifrom 0.x to 1.2.0. Clack 1.0 ships as ESM-only and includes new features like typeahead search in core components.Changes
@clack/core^0.3.2→^1.2.0inpackages/cli@clack/prompts^0.6.3→^1.2.0inpackages/create-cloudflareTextPrompt#valueWithCursorrenamed touserInputWithCursor(Clack breaking change) — updated inpackages/cli/interactive.tsPromptclass now requires a generic parameter —SelectRefreshablePromptandRenderertype updatedstring | voidtostring | Error | undefinedto match Clack's new API — normalisation added inacceptDefault()andpackages/create-cloudflare/src/helpers/args.tsTesting
@cloudflare/cli: type-check passes, 41 unit tests passcreate-cloudflare: type-check passes, 192 unit tests passwrangler: type-check passes, 3703 tests passminiflare: type-check passesc3scaffold flow completes end-to-end,wrangler devboots successfully with Miniflare