[miniflare] Fix source phase imports parsing in module analysis#13238
Merged
petebacondarwin merged 4 commits intomainfrom Apr 2, 2026
Merged
[miniflare] Fix source phase imports parsing in module analysis#13238petebacondarwin merged 4 commits intomainfrom
petebacondarwin merged 4 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 4f37431 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
|
UnknownError: ProviderInitError |
Contributor
|
@guybedford Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
762d667 to
14dd269
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Fixes module parsing to support the TC39 source phase imports proposal (`import source wasm from './module.wasm'`), which is required for WebAssembly ESM integration. Follow-up to #12996 which added wrangler support. Part of #12995. Changes: - Add acorn-import-phases dependency to parse import source syntax - Extend acorn Parser with the import phases plugin in modules.ts - Add test for source phase imports parsing
14dd269 to
4f37431
Compare
petebacondarwin
approved these changes
Apr 2, 2026
workers-devprod
approved these changes
Apr 2, 2026
Contributor
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Merged
NuroDev
pushed a commit
that referenced
this pull request
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes module parsing to support the TC39 source phase imports proposal (
import source wasm from './module.wasm'), which is required for WebAssembly ESM integration.This is a follow-up to #12996 which added wrangler support for source phase imports. While that PR fixed wrangler's esbuild bundling and format detection, miniflare was still failing to parse Workers using this syntax with:
The issue was that miniflare uses acorn directly to analyze module dependencies, and acorn doesn't support the
import sourcesyntax by default. This PR adds theacorn-import-phasesplugin to extend acorn's parser.Part of #12995.