Skip to content

During autoconfig filter out Hono when there are 2 detected frameworks#13193

Merged
ascorbic merged 2 commits intomainfrom
dario/autoconfig-hono-improvement
Apr 2, 2026
Merged

During autoconfig filter out Hono when there are 2 detected frameworks#13193
ascorbic merged 2 commits intomainfrom
dario/autoconfig-hono-improvement

Conversation

@dario-piotrowicz
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz commented Apr 1, 2026

During the auto-configuration process Hono is now treated as an auxiliary framework (like Vite) and automatically filtered out when two frameworks are detected (before Hono was being filtered out only when the other framework was Waku)


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: self explanatory behavior

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 1, 2026

🦋 Changeset detected

Latest commit: 0ae802a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 1, 2026

UnknownError: ProviderInitError

github run

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 1, 2026

@dario-piotrowicz Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@workers-devprod workers-devprod requested review from a team and ascorbic and removed request for a team April 1, 2026 14:35
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Apr 1, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@dario-piotrowicz dario-piotrowicz force-pushed the dario/autoconfig-hono-improvement branch from a96ea94 to e3729e8 Compare April 1, 2026 14:36
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 1, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13193

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13193

miniflare

npm i https://pkg.pr.new/miniflare@13193

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13193

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13193

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13193

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13193

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13193

wrangler

npm i https://pkg.pr.new/wrangler@13193

commit: 0ae802a

@ascorbic ascorbic enabled auto-merge April 2, 2026 11:50
Copy link
Copy Markdown
Contributor

@workers-devprod workers-devprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

✅ All changesets look good

@ascorbic ascorbic added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit 78cbe37 Apr 2, 2026
51 checks passed
@ascorbic ascorbic deleted the dario/autoconfig-hono-improvement branch April 2, 2026 12:34
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants