[vitest-pool-workers] Add 30s timeout to waitUntil promise draining#13083
Merged
[vitest-pool-workers] Add 30s timeout to waitUntil promise draining#13083
Conversation
Previously, if a ctx.waitUntil() promise never resolved, the test suite would hang indefinitely after the test file finished. Now, any waitUntil promises that haven't settled within 30 seconds (aligned with the production Workers platform limit) are abandoned with a warning.
🦋 Changeset detectedLatest commit: 69a3a41 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
✅ All changesets look good |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
|
I'm Bonk, and I've done a quick review of your PR. This PR adds a 30-second timeout to Issues found:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
The previous test went through SELF.fetch() which returns immediately — waitForGlobalWaitUntil() was never called in that lifecycle. The new test calls waitForWaitUntil() directly with a never-resolving promise and verifies it returns after the timeout instead of hanging.
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
edmundhung
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7244.
Previously, if a
ctx.waitUntil()promise never resolved, the test suite would hang indefinitely after the test file finished. Now, anywaitUntilpromises that haven't settled within 30 seconds are abandoned with a warning, allowing the test suite to continue. This aligns with the productionwaitUntillimit.