[wrangler] Fix vitest-pool-workers crashing when assets configured without directory by penalosa · Pull Request #13079 · cloudflare/workers-sdk

penalosa · 2026-03-26T23:33:41Z

When using @cloudflare/vite-plugin, the wrangler config typically has assets: { binding: "ASSETS" } without a directory — the Vite dev server handles asset serving independently. vitest-pool-workers passes the config path to unstable_getMiniflareWorkerOptions, which reads the raw config and calls getAssetsOptions(). That function unconditionally requires directory, so it throws "missing required directory property".

The fix guards the getAssetsOptions() call in both programmatic API callsites (unstable_getMiniflareWorkerOptions and getPlatformProxy) — when no directory is available from either the config or overrides, asset setup is skipped entirely rather than crashing.

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: Bug fix, no new user-facing API

changeset-bot · 2026-03-26T23:33:45Z

🦋 Changeset detected

Latest commit: 9b3bc68

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-03-26T23:34:21Z

✅ All changesets look good

ask-bonk

I'm Bonk, and I've done a quick review of your PR.

Guards getAssetsOptions() in both programmatic API callsites so that assets: { binding: "ASSETS" } without a directory no longer crashes.

Issue: The new fixture is missing a root tsconfig.json, which every other fixture in vitest-pool-workers-examples/ has. This means vitest.config.ts in this fixture won't be type-checked by tsc-all.mjs.

fixtures/vitest-pool-workers-examples/workers-assets-no-dir/vitest.config.ts

ask-bonk · 2026-03-26T23:36:46Z

Review posted successfully on PR #13079. I found one actionable issue:

Missing root tsconfig.json in the new fixture. Every other fixture in vitest-pool-workers-examples/ has a root-level tsconfig.json (extending ../tsconfig.node.json) that covers vitest.config.ts for type-checking via tsc-all.mjs. The new workers-assets-no-dir fixture is the only one missing it, so its vitest.config.ts won't be type-checked during pnpm check:type.

The core logic change in packages/wrangler/src/api/integrations/platform/index.ts is correct — both callsites are properly guarded to skip asset setup when no directory is available.

github run

pkg-pr-new · 2026-03-26T23:37:04Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13079

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13079

miniflare

npm i https://pkg.pr.new/miniflare@13079

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13079

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13079

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13079

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13079

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13079

wrangler

npm i https://pkg.pr.new/wrangler@13079

commit: 9b3bc68

workers-devprod · 2026-03-27T00:32:45Z

Codeowners approval required for this PR:

✅ @cloudflare/wrangler

Show detailed file reviewers

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

.changeset/fix-vitest-pool-workers-assets-no-dir.md

…thout directory

workers-devprod added this to workers-sdk Mar 26, 2026

github-project-automation bot moved this to Untriaged in workers-sdk Mar 26, 2026

ask-bonk bot reviewed Mar 26, 2026

View reviewed changes

fixtures/vitest-pool-workers-examples/workers-assets-no-dir/vitest.config.ts Show resolved Hide resolved

penalosa marked this pull request as ready for review March 27, 2026 00:32

penalosa requested a review from a team as a code owner March 27, 2026 00:32

penalosa requested a review from edmundhung March 27, 2026 00:32

penalosa force-pushed the penalosa/vitest-9381 branch from 9028ba4 to f1278f5 Compare March 27, 2026 00:33

devin-ai-integration bot reviewed Mar 27, 2026

View reviewed changes

edmundhung approved these changes Mar 27, 2026

View reviewed changes

.changeset/fix-vitest-pool-workers-assets-no-dir.md Outdated Show resolved Hide resolved

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 27, 2026

[wrangler] Fix vitest-pool-workers crashing when assets configured wi…

9b3bc68

…thout directory

penalosa force-pushed the penalosa/vitest-9381 branch from f1278f5 to 9b3bc68 Compare March 27, 2026 13:23

penalosa merged commit 746858a into main Mar 27, 2026
58 of 59 checks passed

penalosa deleted the penalosa/vitest-9381 branch March 27, 2026 16:20

github-project-automation bot moved this from Approved to Done in workers-sdk Mar 27, 2026

workers-devprod mentioned this pull request Mar 27, 2026

Version Packages #13096

Merged

penalosa mentioned this pull request Mar 30, 2026

Allow users to run local dev or tests on static asset workers when the assets dir doesn't exist #13116

Draft

5 tasks

workers-devprod mentioned this pull request Mar 31, 2026

Version Packages #13141

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wrangler] Fix vitest-pool-workers crashing when assets configured without directory#13079

[wrangler] Fix vitest-pool-workers crashing when assets configured without directory#13079
penalosa merged 1 commit intomainfrom
penalosa/vitest-9381

penalosa commented Mar 26, 2026 •

edited by devin-ai-integration bot

Loading

Uh oh!

changeset-bot bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

ask-bonk bot left a comment

Uh oh!

Uh oh!

ask-bonk bot commented Mar 26, 2026

Uh oh!

pkg-pr-new bot commented Mar 26, 2026 •

edited

Loading

Uh oh!

workers-devprod commented Mar 27, 2026 •

edited

Loading

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

penalosa commented Mar 26, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ask-bonk bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ask-bonk bot commented Mar 26, 2026

Uh oh!

pkg-pr-new bot commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

workers-devprod commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

penalosa commented Mar 26, 2026 •

edited by devin-ai-integration bot

Loading

changeset-bot bot commented Mar 26, 2026 •

edited

Loading

github-actions bot commented Mar 26, 2026 •

edited

Loading

pkg-pr-new bot commented Mar 26, 2026 •

edited

Loading

workers-devprod commented Mar 27, 2026 •

edited

Loading