[wrangler] fix: resolve secondary worker types when environment overrides worker name#13061
Merged
petebacondarwin merged 2 commits intocloudflare:mainfrom Mar 26, 2026
Conversation
… multi-worker type generation
🦋 Changeset detectedLatest commit: 919c6b3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
jamesopstad
approved these changes
Mar 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12971.
When running
wrangler typeswith multiple-cconfig flags, secondary workers that have named environments which override the worker name (e.g.name: "do-worker"withenv.staging.name: "do-worker-staging") were not being resolved correctly. Any service binding or Durable Object binding in the primary worker that referenced the environment-qualified name (e.g.do-worker-staging) would fall back to an unresolved comment type like:This produced ugly union types in the generated
Envinterface since both the top-level and env-specific bindings could be for different resolved/unresolved types.Root cause: The
secondaryEntriesmap (which maps worker names to their entry file paths) was only populated with the top-level worker name from each secondary config. When a binding referenced an env-qualified name likedo-worker-staging, the lookup missed and fell back to the comment-style unresolved type.Fix: After registering the top-level name for a secondary config, also read the raw config to iterate over all named environments, load the config for each env, and register the env-specific effective name pointing to the same source entry file.