Skip to content

add library-push flag to containers registries credentials#13049

Merged
petebacondarwin merged 2 commits intomainfrom
nsharma/library-push
Mar 25, 2026
Merged

add library-push flag to containers registries credentials#13049
petebacondarwin merged 2 commits intomainfrom
nsharma/library-push

Conversation

@nikitassharma
Copy link
Copy Markdown
Member

@nikitassharma nikitassharma commented Mar 24, 2026

Fixes CC-7318

Adds a --library-push flag to containers regsitries credentials.
No changeset was added as this is an undocumented feature limited to very few accounts.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not a documented flag

A picture of a cute animal (not mandatory, but encouraged)
image


Open with Devin

@nikitassharma nikitassharma requested review from a team as code owners March 24, 2026 22:20
@nikitassharma nikitassharma requested a review from penalosa March 24, 2026 22:20
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 24, 2026

🦋 Changeset detected

Latest commit: e812a1b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 24, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 24, 2026

I've reviewed the changes thoroughly. There is one issue worth flagging: the error message at line 521 was updated to also check --library-push, but the error text still says "You have to specify either --push or --pull" without mentioning --library-push. This means that passing --library-push alone now bypasses this validation (which is intended behavior based on the test), but the error message for a user who passes none of the flags doesn't mention --library-push as an option. Since --library-push is a hidden flag, this is debatable — a user who knows about --library-push won't get a misleading error because they'll pass the flag. But a user who doesn't know about it would have no idea it exists anyway. So the current error message is acceptable for the hidden flag use case.

The changes are clean, minimal, and correct:

  1. The enum value is added properly.
  2. The command arg is hidden: true as intended.
  3. The permissions array construction mirrors the existing pattern for push/pull.
  4. The test covers the new flag.

LGTM

github run

devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 24, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@13049

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@13049

miniflare

npm i https://pkg.pr.new/miniflare@13049

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@13049

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@13049

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@13049

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@13049

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@13049

wrangler

npm i https://pkg.pr.new/wrangler@13049

commit: e812a1b

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 25, 2026
@petebacondarwin
Copy link
Copy Markdown
Contributor

Please add a changeset!

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Issues found

File: .changeset/plenty-paws-rest.md

Issue: Insufficient changelog description

The body of the changeset reads:

This flag is not available for public use.

This does not meet the quality standard. The README guidelines state the body should explain "the reason for the change and anything notable about the approach" and aim for more than one sentence. A note that the flag is not for public use is not a useful changelog entry on its own — it doesn't describe what the flag does, why it was added, or any relevant context for maintainers or future readers.

If this change is truly internal-only and has no user-facing impact, it may not require a changeset at all (per the README: "Changes that are purely internal refactoring with no user-facing impact" do not need one). If it does warrant a changeset, the description should provide more meaningful context about what the library-push flag does and why it was added.

@petebacondarwin
Copy link
Copy Markdown
Contributor

Overriding the changeset review as this is a feature that is only available for certain internal accounts and no need to document more extensively.

@petebacondarwin petebacondarwin merged commit 7a5be20 into main Mar 25, 2026
51 checks passed
@petebacondarwin petebacondarwin deleted the nsharma/library-push branch March 25, 2026 14:11
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 25, 2026
petebacondarwin pushed a commit to tgarg-cf/workers-sdk that referenced this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants