add library-push flag to containers registries credentials#13049
add library-push flag to containers registries credentials#13049petebacondarwin merged 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: e812a1b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
I've reviewed the changes thoroughly. There is one issue worth flagging: the error message at line 521 was updated to also check The changes are clean, minimal, and correct:
LGTM |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
|
Please add a changeset! |
|
File: Issue: Insufficient changelog description The body of the changeset reads:
This does not meet the quality standard. The README guidelines state the body should explain "the reason for the change and anything notable about the approach" and aim for more than one sentence. A note that the flag is not for public use is not a useful changelog entry on its own — it doesn't describe what the flag does, why it was added, or any relevant context for maintainers or future readers. If this change is truly internal-only and has no user-facing impact, it may not require a changeset at all (per the README: "Changes that are purely internal refactoring with no user-facing impact" do not need one). If it does warrant a changeset, the description should provide more meaningful context about what the |
|
Overriding the changeset review as this is a feature that is only available for certain internal accounts and no need to document more extensively. |
Fixes CC-7318
Adds a --library-push flag to
containers regsitries credentials.No changeset was added as this is an undocumented feature limited to very few accounts.
A picture of a cute animal (not mandatory, but encouraged)
