fix(wrangler): run asset directory validation during --dry-run#13036
Merged
petebacondarwin merged 1 commit intocloudflare:mainfrom Mar 24, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: b10d7de The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
petebacondarwin
approved these changes
Mar 24, 2026
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
Merged
petebacondarwin
pushed a commit
to tgarg-cf/workers-sdk
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wrangler deploy --dry-runcurrently skips the entiresyncAssets()call, which means asset directory validation checks (_worker.jsexposure detection, file size limits) are also skipped. A real deploy fails with a clear error, but--dry-runsilently passes.This fix exports
buildAssetManifest()fromassets.tsand calls it during--dry-runwhen assets are configured. This runs the same filesystem validation as a real deploy without deploying anything, making API calls, or altering the behavior or--dry-run.Testing
One new test in
assets.test.tsverifies that--dry-runcatches a_worker.jsfile in the asset directory.Note
The same gap exists in the
wrangler versions upload --dry-runpath. This PR scopes the fix towrangler deploy, butbuildAssetManifestis now exported and available if maintainers want to apply the same check there (either here or in a separate PR).A picture of a cute animal (not mandatory, but encouraged)
Lihn Mai from the National Zoo with her aunt Swarna