[wrangler] Support source phase imports#12996
Merged
petebacondarwin merged 3 commits intomainfrom Mar 25, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: ef02bad The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
Contributor
|
✅ All changesets look good |
Contributor
|
The review is complete. Let me analyze the changes:
The fix is correct and minimal:
LGTM |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
cbfae6c to
ef02bad
Compare
petebacondarwin
approved these changes
Mar 25, 2026
Merged
guybedford
added a commit
that referenced
this pull request
Apr 2, 2026
Fixes module parsing to support the TC39 source phase imports proposal (`import source wasm from './module.wasm'`), which is required for WebAssembly ESM integration. Follow-up to #12996 which added wrangler support. Part of #12995. Changes: - Add acorn-import-phases dependency to parse import source syntax - Extend acorn Parser with the import phases plugin in modules.ts - Add test for source phase imports parsing
5 tasks
guybedford
added a commit
that referenced
this pull request
Apr 2, 2026
Fixes module parsing to support the TC39 source phase imports proposal (`import source wasm from './module.wasm'`), which is required for WebAssembly ESM integration. Follow-up to #12996 which added wrangler support. Part of #12995. Changes: - Add acorn-import-phases dependency to parse import source syntax - Extend acorn Parser with the import phases plugin in modules.ts - Add test for source phase imports parsing
guybedford
added a commit
that referenced
this pull request
Apr 2, 2026
Fixes module parsing to support the TC39 source phase imports proposal (`import source wasm from './module.wasm'`), which is required for WebAssembly ESM integration. Follow-up to #12996 which added wrangler support. Part of #12995. Changes: - Add acorn-import-phases dependency to parse import source syntax - Extend acorn Parser with the import phases plugin in modules.ts - Add test for source phase imports parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12995.
Wrangler's shared esbuild config targeted
es2024without enabling source phase import syntax, which causedimport sourceWasm imports to fail before Wrangler could preserve them in deploy output.This enables esbuild's
import-sourcesyntax support in Wrangler's shared build options so source phase Wasm imports work in both bundled and--no-bundledeploy paths. It also adds regression coverage for worker format detection,wrangler deploy --no-bundle --dry-run, and bundled deploy output written via--outdirand--outfile.A small sea otter successfully carrying a very important pebble.