Add backward-compatible autoconfig support for Astro v5 and v4 projects by dario-piotrowicz · Pull Request #12938 · cloudflare/workers-sdk

dario-piotrowicz · 2026-03-17T12:42:02Z

This PR updates autoconfig to support applications using Astro v5 and v4 while erroring on older versions of astro

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
  - created an astro v5 project and astro v4 project
  - run npx <path-to-wrangler-built> setup
  - validated the output
  - run npm run preview and checked that the application is served correctly
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: UX improvement

A picture of a cute animal (not mandatory, but encouraged)

changeset-bot · 2026-03-17T12:42:13Z

🦋 Changeset detected

Latest commit: c4ba137

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-03-17T12:42:47Z

⚠️ Issues found

`.changeset/sour-lions-march.md`

Version type mismatch: The changeset is marked as patch, but the change adds new functionality — backward-compatible autoconfig support for Astro v4 and v5 projects. Per the changeset guidelines, new features and new configuration options should be minor, not patch. A patch is appropriate for bug fixes and small improvements; introducing new autoconfig logic for multiple Astro version ranges is a new feature.

Recommendation: Change "wrangler": patch to "wrangler": minor.

pkg-pr-new · 2026-03-17T12:45:45Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12938

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12938

miniflare

npm i https://pkg.pr.new/miniflare@12938

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12938

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12938

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12938

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12938

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12938

wrangler

npm i https://pkg.pr.new/wrangler@12938

commit: c4ba137

packages/wrangler/src/autoconfig/frameworks/astro.ts

workers-devprod · 2026-03-17T16:02:19Z

Codeowners approval required for this PR:

✅ @cloudflare/wrangler

Show detailed file reviewers

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>

When tsconfig.json has no explicit 'include' field (common for Astro projects using "extends": "astro/tsconfigs/base"), adding an 'include' array with only worker-configuration.d.ts would override the parent config's includes, breaking type-checking. Instead, warn the user to manually add the entry when no existing 'include' field is found.

When an Astro config already has an import from @astrojs/cloudflare with a different local name (e.g. 'import adapter from "@astrojs/cloudflare"'), the autoconfig now correctly uses that identifier instead of hardcoding 'cloudflare'. This prevents generating broken config with undefined identifiers.

petebacondarwin

LGTM - I tested it with an Astro 4 project, which worked, but I haven't tried out all the different permutations.

dario-piotrowicz · 2026-03-19T18:15:09Z

LGTM - I tested it with an Astro 4 project, which worked, but I haven't tried out all the different permutations.

Thanks! 🫶

I manually tested it with Astro 4, 5 and 6. I didn't test all the different permutations either as there are a few however the code should be correct and if something were not to work as expected we can always fix that later 🙂🙏

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

workers-devprod added this to workers-sdk Mar 17, 2026

github-project-automation bot moved this to Untriaged in workers-sdk Mar 17, 2026

dario-piotrowicz requested a review from ascorbic March 17, 2026 12:43

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

ascorbic reviewed Mar 17, 2026

View reviewed changes

packages/wrangler/src/autoconfig/frameworks/astro.ts Show resolved Hide resolved

dario-piotrowicz requested a review from ascorbic March 17, 2026 15:42

dario-piotrowicz marked this pull request as ready for review March 17, 2026 16:01

dario-piotrowicz requested a review from a team as a code owner March 17, 2026 16:01

This comment was marked as resolved.

Sign in to view

dario-piotrowicz force-pushed the dario/older_astro_config branch from a896799 to 55ec991 Compare March 19, 2026 00:37

This comment was marked as resolved.

Sign in to view

dario-piotrowicz and others added 7 commits March 19, 2026 17:41

Add backward-compatible autoconfig support for Astro v5 and v4 projects

9bfb64b

Update packages/wrangler/src/autoconfig/frameworks/astro.ts

37d9644

Co-authored-by: ask-bonk[bot] <249159057+ask-bonk[bot]@users.noreply.github.com>

set output to hybrid for astro v4 projects

6783ad2

add missing isWorkspaceRoot flag

5070de8

fix formatting

46da614

dario-piotrowicz force-pushed the dario/older_astro_config branch from 12435b0 to 46da614 Compare March 19, 2026 17:44

This comment was marked as resolved.

Sign in to view

petebacondarwin approved these changes Mar 19, 2026

View reviewed changes

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 19, 2026

Update packages/wrangler/src/autoconfig/frameworks/astro.ts

cdc0445

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

This comment was marked as resolved.

Sign in to view

Update packages/wrangler/src/autoconfig/frameworks/astro.ts

c4ba137

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>

dario-piotrowicz merged commit 71ab981 into main Mar 19, 2026
36 checks passed

dario-piotrowicz deleted the dario/older_astro_config branch March 19, 2026 19:02

github-project-automation bot moved this from Approved to Done in workers-sdk Mar 19, 2026

workers-devprod mentioned this pull request Mar 19, 2026

Version Packages #12945

Merged

Conversation

dario-piotrowicz commented Mar 17, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

.changeset/sour-lions-march.md

Uh oh!

pkg-pr-new bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as outdated.

Uh oh!

workers-devprod commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

This comment was marked as resolved.

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz commented Mar 19, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dario-piotrowicz commented Mar 17, 2026 •

edited by devin-ai-integration bot

Loading

changeset-bot bot commented Mar 17, 2026 •

edited

Loading

github-actions bot commented Mar 17, 2026 •

edited

Loading

`.changeset/sour-lions-march.md`

pkg-pr-new bot commented Mar 17, 2026 •

edited

Loading

workers-devprod commented Mar 17, 2026 •

edited

Loading