Skip to content

Ungate local explorer#12848

Merged
NuroDev merged 8 commits intomainfrom
emily/slightly-ungatae-le
Mar 18, 2026
Merged

Ungate local explorer#12848
NuroDev merged 8 commits intomainfrom
emily/slightly-ungatae-le

Conversation

@emily-shen
Copy link
Copy Markdown
Contributor

@emily-shen emily-shen commented Mar 11, 2026 •
edited
Loading

This ungates the local explorer by setting X_LOCAL_EXPLORER=true by default. This can still be disabled by setting the env var to false. Also, the hotkey [e] remains hidden, but functional.

Note i've removed the header changes and that is now here: #12869

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: still experimental

A picture of a cute animal (not mandatory, but encouraged)

Open with Devin

@emily-shen emily-shen requested a review from a team as a code owner March 11, 2026 15:27
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 11, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 53df344

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 11, 2026
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 11, 2026 •
edited
Loading

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 11, 2026 •
edited
Loading

✅ All changesets look good

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 11, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 11, 2026 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12848

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12848

miniflare

npm i https://pkg.pr.new/miniflare@12848

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12848

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12848

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12848

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12848

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12848

wrangler

npm i https://pkg.pr.new/wrangler@12848

commit: 53df344

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@emily-shen
Copy link
Copy Markdown
Contributor Author

emily-shen commented Mar 11, 2026

/bonk remove the test should show local explorer hotkey when X_LOCAL_EXPLORER=true

ask-bonk[bot]
ask-bonk bot approved these changes Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, straightforward ungating. The test restructuring makes sense — the default case no longer needs X_LOCAL_EXPLORER=true to be explicit, and the opt-out path (X_LOCAL_EXPLORER=false) is properly tested.

One minor observation: as Devin flagged, the [e] hotkey is now always active (no disabled check), so pressing e when X_LOCAL_EXPLORER=false will open a browser to /cdn-cgi/explorer where the explorer isn't served. Emily confirmed this is intentional since the hotkey is hidden anyway, so this is fine — a user would have to know about the hotkey and deliberately press it while also having explicitly disabled the feature, which is an unlikely edge case.

LGTM.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Mar 11, 2026

Reviewed and approved PR #12848. The changes are clean:

  1. misc-variables.ts: X_LOCAL_EXPLORER default flipped from false to true — the core ungating change.
  2. hotkeys.ts: The [e] hotkey label is commented out (hidden but functional), and the disabled guard and unused import are removed.
  3. Test file: The outer describe("with X_LOCAL_EXPLORER=true") wrapper is removed since the default now enables the explorer. The disabled-path test is updated to explicitly set X_LOCAL_EXPLORER=false. The test name was already corrected (matching Devin's suggestion) in a follow-up commit.
  4. Changeset: Correctly marked as minor for all three affected packages.

github run

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@emily-shen emily-shen force-pushed the emily/slightly-ungatae-le branch from 39da40b to 1c3a666 Compare March 12, 2026 14:18
devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

edmundhung
edmundhung reviewed Mar 12, 2026
View reviewed changes
edmundhung
edmundhung reviewed Mar 12, 2026
View reviewed changes
@emily-shen
Copy link
Copy Markdown
Contributor Author

emily-shen commented Mar 12, 2026 •
edited
Loading

We need to block this until we resolve the cors etc. issues properly, since this will expose the explorer api on all user dev sessions by default.

edit: cors issues will be resolved here: #12869
but i still think maybe we should wait until we get some people to test it out internally

NuroDev
NuroDev reviewed Mar 12, 2026
View reviewed changes
emily-shen and others added 5 commits March 13, 2026 16:24
@emily-shen
ungate local explorer
8238d90
@emily-shen
update tests
7a0d069
@emily-shen
changeset
2d7a791
@emily-shen @devin-ai-integration
Update fixtures/worker-with-resources/tests/index.test.ts
3f61ebc 
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@emily-shen
fix test
8d51aee
@emily-shen emily-shen force-pushed the emily/slightly-ungatae-le branch from 1c3a666 to 936e3ff Compare March 13, 2026 16:25
@emily-shen emily-shen force-pushed the emily/slightly-ungatae-le branch from 936e3ff to 7c49cfa Compare March 13, 2026 16:26
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 17, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@NuroDev NuroDev merged commit ce48b77 into main Mar 18, 2026
36 checks passed
@NuroDev NuroDev deleted the emily/slightly-ungatae-le branch March 18, 2026 10:47
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 18, 2026
@workers-devprod workers-devprod mentioned this pull request Mar 18, 2026
Merged
NuroDev added a commit that referenced this pull request Mar 18, 2026
@emily-shen @devin-ai-integration @NuroDev
Ungate local explorer (#12848)
fef74d2 
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Ben <4991309+NuroDev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NuroDev NuroDev NuroDev approved these changes

@edmundhung edmundhung edmundhung left review comments

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@ask-bonk ask-bonk[bot] ask-bonk[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emily-shen @workers-devprod @NuroDev @edmundhung