Skip to content

fix: bump vulnerable direct dependencies#12790

Merged
petebacondarwin merged 1 commit intomainfrom
fix/bump-vulnerable-direct-deps
Mar 6, 2026
Merged

fix: bump vulnerable direct dependencies#12790
petebacondarwin merged 1 commit intomainfrom
fix/bump-vulnerable-direct-deps

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin commented Mar 6, 2026

Addresses https://github.com/cloudflare/workers-sdk/security/dependabot

Summary

Bumps direct dependencies with known security vulnerabilities to their patched versions. This resolves ~28 of the 112 open Dependabot alerts.

Changes

Package Previous Updated Affected packages Alerts resolved
hono ^4.7.0 / ^4.11.5 ^4.12.5 miniflare, playground-preview-worker, turbo-r2-archive 13 (arbitrary file access, JWT confusion, XSS, auth bypass, etc.)
devalue ^5.3.2 ^5.6.3 miniflare, vitest-pool-workers 4 (DoS via memory/CPU exhaustion, prototype pollution)
node-forge ^1.3.1 ^1.3.2 wrangler 3 (ASN.1 unbounded recursion, OID truncation, validator desynch)
glob ^10.3.3 / ^10.4.5 ^10.5.0 create-cloudflare, pages-shared 1 (command injection in glob CLI)
vite (catalog) ^5.4.14 ^5.4.21 all packages using default catalog 7 (multiple server.fs.deny bypasses)

Additional fixes

  • Fixed type errors in miniflare/src/workers/local-explorer/resources/d1.ts and kv.ts caused by hono 4.12's stricter c.req.param() return type (string | undefined instead of string). Added runtime parameter validation guards.
  • Updated vitest>vite pnpm override from "^5.0.0" to "catalog:default" to keep vitest's vite version in sync with the catalog, preventing type mismatches.

Remaining alerts

~84 alerts remain, mostly from transitive dependencies and false positives (self-referential alerts for wrangler/vite-plugin workspace packages). These can be addressed in follow-up PRs via pnpm overrides and fixture updates.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because: dependency version bumps only; all packages build successfully; CI will validate
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal dependency updates with no API changes

Open with Devin

Bump direct dependencies to address Dependabot security alerts:
- hono: ^4.7.0/^4.11.5 -> ^4.12.5 (13 alerts: arbitrary file access, JWT confusion, XSS, etc.)
- devalue: ^5.3.2 -> ^5.6.3 (4 alerts: DoS, prototype pollution)
- node-forge: ^1.3.1 -> ^1.3.2 (3 alerts: ASN.1 vulnerabilities)
- glob: ^10.3.3/^10.4.5 -> ^10.5.0 (1 alert: command injection in CLI)
- vite catalog: ^5.4.14 -> ^5.4.21 (7 alerts: server.fs.deny bypasses)

Also fixes type errors in miniflare's local-explorer workers caused by
hono 4.12's stricter c.req.param() return type (string | undefined).
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 6, 2026

🦋 Changeset detected

Latest commit: 6f361a7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2026

✅ All changesets look good

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 6, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12790

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12790

miniflare

npm i https://pkg.pr.new/miniflare@12790

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12790

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12790

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12790

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12790

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12790

wrangler

npm i https://pkg.pr.new/wrangler@12790

commit: 91910a1

@petebacondarwin petebacondarwin added the preview:workers-playground Trigger a workers playground preview deploy label Mar 6, 2026
@petebacondarwin petebacondarwin marked this pull request as ready for review March 6, 2026 15:11
@petebacondarwin petebacondarwin requested a review from a team as a code owner March 6, 2026 15:11
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 6, 2026

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 6, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@petebacondarwin petebacondarwin merged commit 5451a7f into main Mar 6, 2026
44 of 49 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 6, 2026
@petebacondarwin petebacondarwin deleted the fix/bump-vulnerable-direct-deps branch March 6, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:workers-playground Trigger a workers playground preview deploy

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants