Fix autoconfig package installation always failing at workspace roots by dario-piotrowicz · Pull Request #12676 · cloudflare/workers-sdk

dario-piotrowicz · 2026-02-25T16:18:59Z

When running autoconfig at the root of a monorepo workspace, package installation commands now include the appropriate workspace root flags (--workspace-root for pnpm, -W for yarn). This prevents errors like "Running this command will add the dependency to the workspace root" that previously occurred when configuring projects at the workspace root.

Additionally, autoconfig now allows running at the workspace root if the root directory itself is listed as a workspace package (e.g., workspaces: ["packages/*", "."]).

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: expected behavior

A picture of a cute animal (not mandatory, but encouraged)

changeset-bot · 2026-02-25T16:19:04Z

🦋 Changeset detected

Latest commit: 7b476e1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

claude · 2026-02-25T16:19:24Z

Claude encountered an error —— View job

Changeset Review

Todo List:

Read changeset guidelines
Review changeset file
Check for cute animal images
Provide final assessment

pkg-pr-new · 2026-02-25T16:27:54Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12676

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12676

miniflare

npm i https://pkg.pr.new/miniflare@12676

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12676

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12676

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12676

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12676

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12676

wrangler

npm i https://pkg.pr.new/wrangler@12676

commit: 2c90eb0

devin-ai-integration

Devin Review found 1 new potential issue.

🐛 1 issue in files not directly in the diff

🐛 react-router framework missing isWorkspaceRoot in installPackages calls (`packages/wrangler/src/autoconfig/frameworks/react-router.ts:146-157`)

The ReactRouter.configure() method does not destructure isWorkspaceRoot from ConfigurationOptions and does not pass it to its two installPackages calls (lines 153 and 190). Every other framework that calls installPackages was updated in this PR to pass isWorkspaceRoot, but react-router.ts was missed.

Detailed Explanation

At packages/wrangler/src/autoconfig/frameworks/react-router.ts:146-149, the destructuring only extracts dryRun, projectPath, and packageManager:

async configure({
    dryRun,
    projectPath,
    packageManager,
}: ConfigurationOptions)

But isWorkspaceRoot is now a required field on ConfigurationOptions (packages/wrangler/src/autoconfig/frameworks/index.ts:11). The two installPackages calls at lines 153 and 190 don't include isWorkspaceRoot in their config objects.

Impact: When running autoconfig for a React Router project at the root of a monorepo workspace, the installPackages calls will not include workspace root flags (--workspace-root for pnpm, -W for yarn), causing the same "Running this command will add the dependency to the workspace root" errors that this PR is supposed to fix.

View 7 additional findings in Devin Review.

github-actions · 2026-03-02T11:51:39Z

✅ All changesets look good

devin-ai-integration

Devin Review found 1 new potential issue.

🐛 1 issue in files not directly in the diff

🐛 react-router framework missing isWorkspaceRoot in installPackages calls (`packages/wrangler/src/autoconfig/frameworks/react-router.ts:146-157`)

The ReactRouter.configure() method does not destructure isWorkspaceRoot from ConfigurationOptions and does not pass it to its two installPackages calls (lines 153 and 190). Every other framework that calls installPackages was updated in this PR to pass isWorkspaceRoot, but react-router.ts was missed.

Detailed Explanation

At packages/wrangler/src/autoconfig/frameworks/react-router.ts:146-149, the destructuring only extracts dryRun, projectPath, and packageManager:

async configure({
    dryRun,
    projectPath,
    packageManager,
}: ConfigurationOptions)

But isWorkspaceRoot is now a required field on ConfigurationOptions (packages/wrangler/src/autoconfig/frameworks/index.ts:11). The two installPackages calls at lines 153 and 190 don't include isWorkspaceRoot in their config objects.

Impact: When running autoconfig for a React Router project at the root of a monorepo workspace, the installPackages calls will not include workspace root flags (--workspace-root for pnpm, -W for yarn), causing the same "Running this command will add the dependency to the workspace root" errors that this PR is supposed to fix.

View 7 additional findings in Devin Review.

packages/wrangler/src/autoconfig/c3-vendor/packages.ts

petebacondarwin · 2026-03-04T21:33:18Z

Probably worth addressing the Devin issue too?

Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>

devin-ai-integration

Devin Review found 1 new potential issue.

🐛 1 issue in files not directly in the diff

🐛 react-router framework missing isWorkspaceRoot in installPackages calls (`packages/wrangler/src/autoconfig/frameworks/react-router.ts:146-157`)

The ReactRouter.configure() method does not destructure isWorkspaceRoot from ConfigurationOptions and does not pass it to its two installPackages calls (lines 153 and 190). Every other framework that calls installPackages was updated in this PR to pass isWorkspaceRoot, but react-router.ts was missed.

Detailed Explanation

At packages/wrangler/src/autoconfig/frameworks/react-router.ts:146-149, the destructuring only extracts dryRun, projectPath, and packageManager:

async configure({
    dryRun,
    projectPath,
    packageManager,
}: ConfigurationOptions)

But isWorkspaceRoot is now a required field on ConfigurationOptions (packages/wrangler/src/autoconfig/frameworks/index.ts:11). The two installPackages calls at lines 153 and 190 don't include isWorkspaceRoot in their config objects.

Impact: When running autoconfig for a React Router project at the root of a monorepo workspace, the installPackages calls will not include workspace root flags (--workspace-root for pnpm, -W for yarn), causing the same "Running this command will add the dependency to the workspace root" errors that this PR is supposed to fix.

View 8 additional findings in Devin Review.

dario-piotrowicz · 2026-03-05T11:16:58Z

Probably worth addressing the Devin issue too?

good call, addressed! 🙂

dario-piotrowicz requested a review from a team as a code owner February 25, 2026 16:19

workers-devprod added this to workers-sdk Feb 25, 2026

github-project-automation bot moved this to Untriaged in workers-sdk Feb 25, 2026

This comment was marked as resolved.

Sign in to view

dario-piotrowicz force-pushed the dario/autoconfig-monorepo-root-improvement branch 3 times, most recently from b3c3c29 to 7430698 Compare February 25, 2026 18:03

This comment was marked as resolved.

Sign in to view

dario-piotrowicz force-pushed the dario/autoconfig-monorepo-root-improvement branch from 7430698 to f83ab21 Compare February 26, 2026 18:40

devin-ai-integration bot reviewed Feb 26, 2026

View reviewed changes

Fix autoconfig package installation always failing at workspace root

dbcf13e

dario-piotrowicz force-pushed the dario/autoconfig-monorepo-root-improvement branch from f83ab21 to dbcf13e Compare March 2, 2026 11:51

devin-ai-integration bot reviewed Mar 2, 2026

View reviewed changes

petebacondarwin approved these changes Mar 4, 2026

View reviewed changes

packages/wrangler/src/autoconfig/c3-vendor/packages.ts Outdated Show resolved Hide resolved

packages/wrangler/src/autoconfig/c3-vendor/packages.ts Outdated Show resolved Hide resolved

packages/wrangler/src/autoconfig/c3-vendor/packages.ts Show resolved Hide resolved

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 4, 2026

dario-piotrowicz and others added 2 commits March 5, 2026 11:12

Update packages/wrangler/src/autoconfig/c3-vendor/packages.ts

0917bfa

Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>

Update packages/wrangler/src/autoconfig/c3-vendor/packages.ts

b9332c2

Co-authored-by: Pete Bacon Darwin <pete@bacondarwin.com>

devin-ai-integration bot reviewed Mar 5, 2026

View reviewed changes

add missing isWorkspaceRoot

74da69d

This comment was marked as resolved.

Sign in to view

add another missing isWorkspaceRoot

7b476e1

dario-piotrowicz merged commit 65f1092 into main Mar 15, 2026
58 of 64 checks passed

dario-piotrowicz deleted the dario/autoconfig-monorepo-root-improvement branch March 15, 2026 23:00

github-project-automation bot moved this from Approved to Done in workers-sdk Mar 15, 2026

workers-devprod mentioned this pull request Mar 15, 2026

Version Packages #12876

Merged

Conversation

dario-piotrowicz commented Feb 25, 2026 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

claude bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset Review

Uh oh!

This comment was marked as resolved.

Uh oh!

pkg-pr-new bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

🐛 react-router framework missing isWorkspaceRoot in installPackages calls (packages/wrangler/src/autoconfig/frameworks/react-router.ts:146-157)

Uh oh!

github-actions bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

🐛 react-router framework missing isWorkspaceRoot in installPackages calls (packages/wrangler/src/autoconfig/frameworks/react-router.ts:146-157)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

petebacondarwin commented Mar 4, 2026

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

🐛 react-router framework missing isWorkspaceRoot in installPackages calls (packages/wrangler/src/autoconfig/frameworks/react-router.ts:146-157)

Uh oh!

dario-piotrowicz commented Mar 5, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dario-piotrowicz commented Feb 25, 2026 •

edited by devin-ai-integration bot

Loading

changeset-bot bot commented Feb 25, 2026 •

edited

Loading

claude bot commented Feb 25, 2026 •

edited

Loading

pkg-pr-new bot commented Feb 25, 2026 •

edited

Loading

🐛 react-router framework missing isWorkspaceRoot in installPackages calls (`packages/wrangler/src/autoconfig/frameworks/react-router.ts:146-157`)

github-actions bot commented Mar 2, 2026 •

edited

Loading

🐛 react-router framework missing isWorkspaceRoot in installPackages calls (`packages/wrangler/src/autoconfig/frameworks/react-router.ts:146-157`)

🐛 react-router framework missing isWorkspaceRoot in installPackages calls (`packages/wrangler/src/autoconfig/frameworks/react-router.ts:146-157`)