[wrangler][C3] Use qwik add cloudflare-workers instead of cloudflare-pages by MattieTK · Pull Request #12569 · cloudflare/workers-sdk

MattieTK · 2026-02-16T08:28:39Z

Fixes https://jira.cfdata.org/browse/DEVX-2443

Use the correct Qwik adapter (cloudflare-workers) when targeting Workers, instead of running the Pages adapter and cleaning up after it.

Both the wrangler autoconfig (packages/wrangler/src/autoconfig/frameworks/qwik.ts) and the C3 Workers template (packages/create-cloudflare/templates/qwik/workers/c3.ts) were running qwik add cloudflare-pages even when targeting Cloudflare Workers. This caused the wrong adapter directory structure to be scaffolded (adapters/cloudflare-pages/ instead of adapters/cloudflare-workers/), and required post-hoc cleanup of Pages-specific files like _routes.json and manual creation of .assetsignore.

Qwik provides a dedicated cloudflare-workers adapter (qwik add cloudflare-workers) that generates the correct Workers configuration out of the box:

adapters/cloudflare-workers/vite.config.ts (correct adapter directory)
wrangler.jsonc with main and assets fields
public/.assetsignore with the correct entries
Workers-appropriate package.json scripts

Changes

packages/wrangler/src/autoconfig/frameworks/qwik.ts:

qwik add cloudflare-pages → qwik add cloudflare-workers
Added --skipConfirmation=true to skip Qwik's interactive prompt
Removed addAssetsIgnoreFile() function (the adapter now generates this)
Removed unused writeFile import
Updated configurationDescription string

packages/create-cloudflare/templates/qwik/workers/c3.ts:

qwik add cloudflare-pages → qwik add cloudflare-workers
Added --skipConfirmation=true
Removed removeFile("./public/_routes.json") (the workers adapter doesn't generate this)
Removed unused removeFile import

packages/create-cloudflare/templates/qwik/pages/c3.ts:

Added --skipConfirmation=true for consistency

Tests
- Tests included/updated
- Automated tests not possible - manual testing has been completed as follows:
- Additional testing not necessary because: The Qwik E2E tests are currently quarantined due to upstream eslint compatibility issues. The autoconfig unit tests that ran (18/18) all pass. The change is a direct swap of the adapter name argument with cleanup of now-unnecessary workarounds.
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: This aligns the tooling with Qwik's existing documentation for the cloudflare-workers deployment target.

changeset-bot · 2026-02-16T08:28:44Z

🦋 Changeset detected

Latest commit: b8fa700

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

claude · 2026-02-16T08:29:06Z

Claude finished @MattieTK's task —— View job

Changeset Review

✅ All changesets look good

The changeset file .changeset/fix-qwik-adapter.md follows all the guidelines:

Version Type: patch for both wrangler and create-cloudflare is appropriate for this bug fix
Changelog Quality: The description is clear and well-structured, explaining both the problem and the solution
Markdown Headers: No h1/h2/h3 headers present
Analytics: No analytics changes in this PR
Format: Follows the recommended format with a clear title and detailed body explaining the issue and fix

The changeset properly covers both affected packages and provides good context about why the change was necessary.

packages/wrangler/src/autoconfig/frameworks/qwik.ts

pkg-pr-new · 2026-02-16T08:32:24Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12569

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12569

miniflare

npm i https://pkg.pr.new/miniflare@12569

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12569

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12569

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12569

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12569

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12569

wrangler

npm i https://pkg.pr.new/wrangler@12569

commit: b8fa700

devin-ai-integration

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

dario-piotrowicz

Looks good to me, thanks @MattieTK 🙂

petebacondarwin

Note that the qwik C3 tests are all quarantined right now, so they are not being tested in CI!

dario-piotrowicz · 2026-02-16T13:16:20Z

Note that the qwik C3 tests are all quarantined right now, so they are not being tested in CI!

yeah you're right... 😓 it's also difficult to check wether these changes are valid given the fact that the quick CLI currently produces borken apps 😓

github-actions · 2026-03-19T11:01:22Z

✅ All changesets look good

workers-devprod · 2026-03-19T11:01:26Z

Codeowners approval required for this PR:

✅ @cloudflare/wrangler

Show detailed file reviewers

…Workers targets Switch both the wrangler autoconfig and C3 Workers template for Qwik from 'qwik add cloudflare-pages' to 'qwik add cloudflare-workers'. The cloudflare-workers adapter generates the correct Workers-specific scaffolding (adapters/cloudflare-workers/, .assetsignore, wrangler.jsonc with main + assets fields), removing the need for post-hoc cleanup of Pages-specific files. Also adds --skipConfirmation=true to all qwik add invocations so the interactive prompt is skipped in automated contexts.

workers-devprod added this to workers-sdk Feb 16, 2026

github-project-automation bot moved this to Untriaged in workers-sdk Feb 16, 2026

MattieTK commented Feb 16, 2026

View reviewed changes

packages/wrangler/src/autoconfig/frameworks/qwik.ts Show resolved Hide resolved

MattieTK marked this pull request as ready for review February 16, 2026 08:36

MattieTK requested a review from a team as a code owner February 16, 2026 08:36

devin-ai-integration bot reviewed Feb 16, 2026

View reviewed changes

dario-piotrowicz approved these changes Feb 16, 2026

View reviewed changes

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Feb 16, 2026

petebacondarwin reviewed Feb 16, 2026

View reviewed changes

MattieTK force-pushed the mattietk/fix-qwik-adapter branch from 2788057 to 83d89ef Compare February 19, 2026 15:17

MattieTK force-pushed the mattietk/fix-qwik-adapter branch from 664bb17 to b8fa700 Compare March 20, 2026 10:05

MattieTK merged commit 379f2a2 into main Mar 20, 2026
45 checks passed

MattieTK deleted the mattietk/fix-qwik-adapter branch March 20, 2026 10:36

github-project-automation bot moved this from Approved to Done in workers-sdk Mar 20, 2026

workers-devprod mentioned this pull request Mar 20, 2026

Version Packages #12980

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wrangler][C3] Use qwik add cloudflare-workers instead of cloudflare-pages#12569

[wrangler][C3] Use qwik add cloudflare-workers instead of cloudflare-pages#12569
MattieTK merged 1 commit intomainfrom
mattietk/fix-qwik-adapter

MattieTK commented Feb 16, 2026 •

edited by dario-piotrowicz

Loading

Uh oh!

changeset-bot bot commented Feb 16, 2026 •

edited

Loading

Uh oh!

claude bot commented Feb 16, 2026 •

edited

Loading

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 16, 2026 •

edited

Loading

Uh oh!

devin-ai-integration bot left a comment

Uh oh!

dario-piotrowicz left a comment

Uh oh!

petebacondarwin left a comment

Uh oh!

dario-piotrowicz commented Feb 16, 2026

Uh oh!

github-actions bot commented Mar 19, 2026 •

edited

Loading

Uh oh!

workers-devprod commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

MattieTK commented Feb 16, 2026 • edited by dario-piotrowicz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

changeset-bot bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

claude bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset Review

Uh oh!

Uh oh!

pkg-pr-new bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration bot left a comment

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

dario-piotrowicz left a comment

Choose a reason for hiding this comment

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

dario-piotrowicz commented Feb 16, 2026

Uh oh!

github-actions bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

workers-devprod commented Mar 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MattieTK commented Feb 16, 2026 •

edited by dario-piotrowicz

Loading

changeset-bot bot commented Feb 16, 2026 •

edited

Loading

claude bot commented Feb 16, 2026 •

edited

Loading

pkg-pr-new bot commented Feb 16, 2026 •

edited

Loading

github-actions bot commented Mar 19, 2026 •

edited

Loading