Merged
Conversation
🦋 Changeset detectedLatest commit: f27afe7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Claude finished @emily-shen's task —— View job Changeset Review
✅ All changesets look good The changeset
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
66018cd to
5263a88
Compare
5263a88 to
c6648c9
Compare
d861d25 to
bb007dd
Compare
bb007dd to
30811e0
Compare
30811e0 to
054e1c0
Compare
since it will serve assets too
054e1c0 to
c998137
Compare
447c566 to
c998137
Compare
vicb
reviewed
Feb 5, 2026
vicb
reviewed
Feb 5, 2026
vicb
reviewed
Feb 5, 2026
packages/miniflare/src/workers/local-explorer/explorer.worker.ts
Outdated
Show resolved
Hide resolved
vicb
reviewed
Feb 5, 2026
petebacondarwin
approved these changes
Feb 5, 2026
| */ | ||
| function copyLocalExplorerUi(outPath, pkgRoot) { | ||
| const localExplorerUiSrc = path.join(pkgRoot, "../local-explorer-ui/dist"); | ||
| const localExplorerUiDest = path.join(outPath, "local-explorer-ui"); |
Contributor
There was a problem hiding this comment.
I wonder if it is worth putting "local-explorer-ui and similar into constants that can be shared with the Miniflare plugin, just to avoid accidentally missing some when we inevitably rename or relocate this stuff?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By commit:
Reasoning:
This is not using the existing miniflare asset plugin (ie what workers assets uses). Instead, I've got the explorer worker to serve and route the assets instead using miniflare disk binding. I considered using the existing asset plugin, but there's no nice way right now to add a plugin to a plugin, and the plumbing ends up being quite convoluted to wire up all the components of the asset plugin. The current solution ends up being a lot fewer LOC.
A picture of a cute animal (not mandatory, but encouraged)