Skip to content

Serve explorer ui from miniflare#12391

Merged
emily-shen merged 6 commits intomainfrom
emily/ui-serving
Feb 5, 2026
Merged

Serve explorer ui from miniflare#12391
emily-shen merged 6 commits intomainfrom
emily/ui-serving

Conversation

@emily-shen
Copy link
Copy Markdown
Contributor

@emily-shen emily-shen commented Feb 3, 2026

By commit:

  1. Copies over the built files from local-explorer-ui to miniflare during miniflare's build
  2. Rename to explorer.worker.ts instead of api.worker.ts
  3. add asset serving to explorer worker

Reasoning:
This is not using the existing miniflare asset plugin (ie what workers assets uses). Instead, I've got the explorer worker to serve and route the assets instead using miniflare disk binding. I considered using the existing asset plugin, but there's no nice way right now to add a plugin to a plugin, and the plumbing ends up being quite convoluted to wire up all the components of the asset plugin. The current solution ends up being a lot fewer LOC.


  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: wip experimental thing

A picture of a cute animal (not mandatory, but encouraged)


Open with Devin

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 3, 2026

🦋 Changeset detected

Latest commit: f27afe7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link
Copy Markdown
Contributor

claude bot commented Feb 3, 2026

Claude finished @emily-shen's task —— View job


Changeset Review

  • Read changeset guidelines
  • Review changeset file
  • Validate against criteria
  • Check for cute animal images
  • Post results

✅ All changesets look good

The changeset .changeset/witty-dolls-win.md passes all validation criteria:

  • ✅ Version type: minor is appropriate for a new experimental feature
  • ✅ Changelog quality: Clear, meaningful description
  • ✅ Markdown headers: No h1/h2/h3 headers used
  • ✅ Analytics: N/A
  • ✅ Experimental features: Includes note that this is an experimental, WIP feature ✨

@emily-shen emily-shen marked this pull request as ready for review February 3, 2026 17:35
@emily-shen emily-shen requested a review from a team as a code owner February 3, 2026 17:35
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 3, 2026

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@12391

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@12391

miniflare

npm i https://pkg.pr.new/miniflare@12391

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@12391

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@12391

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@12391

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@12391

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@12391

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@12391

wrangler

npm i https://pkg.pr.new/wrangler@12391

commit: f27afe7

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 6 additional flags.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View issue and 10 additional flags in Devin Review.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View issue and 10 additional flags in Devin Review.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

View issues and 13 additional flags in Devin Review.

Open in Devin Review

@emily-shen emily-shen changed the title wip: serve explorer ui from miniflare Serve explorer ui from miniflare Feb 4, 2026
@emily-shen emily-shen force-pushed the emily/ui-serving branch 2 times, most recently from 447c566 to c998137 Compare February 4, 2026 16:53
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View issue and 19 additional flags in Devin Review.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

*/
function copyLocalExplorerUi(outPath, pkgRoot) {
const localExplorerUiSrc = path.join(pkgRoot, "../local-explorer-ui/dist");
const localExplorerUiDest = path.join(outPath, "local-explorer-ui");
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it is worth putting "local-explorer-ui and similar into constants that can be shared with the Miniflare plugin, just to avoid accidentally missing some when we inevitably rename or relocate this stuff?

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Feb 5, 2026
@emily-shen emily-shen merged commit ce9dc01 into main Feb 5, 2026
49 of 54 checks passed
@emily-shen emily-shen deleted the emily/ui-serving branch February 5, 2026 14:34
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants