Skip to content

Remove cf-requirements support from wrangler#11899

Merged
petebacondarwin merged 4 commits intomainfrom
hoodmane/python-remove-cf-requirements
Mar 23, 2026
Merged

Remove cf-requirements support from wrangler#11899
petebacondarwin merged 4 commits intomainfrom
hoodmane/python-remove-cf-requirements

Conversation

@hoodmane
Copy link
Copy Markdown
Contributor

@hoodmane hoodmane commented Jan 13, 2026 •
edited by petebacondarwin
Loading

Instead warn that it is deprecated. It hasn't worked for a while now.

  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not mentioned in the docs
Open with Devin

@hoodmane hoodmane requested a review from a team as a code owner January 13, 2026 17:32
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 13, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: bb83491

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jan 13, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jan 13, 2026 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11899

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11899

miniflare

npm i https://pkg.pr.new/miniflare@11899

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11899

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11899

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11899

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11899

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11899

wrangler

npm i https://pkg.pr.new/wrangler@11899

commit: bb83491

emily-shen
emily-shen reviewed Jan 16, 2026
View reviewed changes
@petebacondarwin petebacondarwin force-pushed the hoodmane/python-remove-cf-requirements branch from 7ba4834 to d350fba Compare March 14, 2026 16:40
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 14, 2026 •
edited
Loading

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/workers-playground/generate-default-hashes.ts: [@cloudflare/wrangler]
  • packages/workers-playground/src/QuickEditor/defaultHashes.js: [@cloudflare/wrangler]
  • packages/workers-playground/src/QuickEditor/useDraftWorker.ts: [@cloudflare/wrangler]
  • packages/workers-playground/welcome/cf-requirements.txt: [@cloudflare/wrangler]
  • packages/wrangler/src/deployment-bundle/find-additional-modules.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/dev/use-esbuild.ts: [@cloudflare/wrangler]

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2026 •
edited
Loading

✅ All changesets look good

devin-ai-integration[bot]
devin-ai-integration bot reviewed Mar 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

🐛 1 issue in files not directly in the diff

🐛 defaultHashes.js not regenerated after removing cf-requirements.txt from Python worker (packages/workers-playground/src/QuickEditor/defaultHashes.js:6)

The generate-default-hashes.ts script was updated to remove cf-requirements.txt from the Python worker FormData, but the generated defaultHashes.js file was not regenerated. The committed defaultHashes.js at packages/workers-playground/src/QuickEditor/defaultHashes.js:6 still contains the old serialized FormData with cf-requirements.txt embedded in the worker string. This will cause the check:default-hashes CI step (packages/workers-playground/package.json:9) to fail, as assert.deepEqual in the check mode (packages/workers-playground/generate-default-hashes.ts:111) will detect the mismatch between the stale committed file and the freshly generated hashes. The developer needs to run pnpm run generate:default-hashes in the packages/workers-playground directory to update the file.

View 4 additional findings in Devin Review.

Open in Devin Review

@penalosa penalosa force-pushed the hoodmane/python-remove-cf-requirements branch from 322bba0 to 5b538d0 Compare March 20, 2026 20:12
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 20, 2026 •
edited
Loading

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

petebacondarwin
petebacondarwin approved these changes Mar 23, 2026
View reviewed changes
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 23, 2026
hoodmane and others added 2 commits March 23, 2026 08:49
@hoodmane @petebacondarwin
Remove cf-requirements support from wrangler
a7f372f 
Instead warn that it is deprecated.
It hasn't worked for a while now.
@petebacondarwin
Remove dead isValidPythonPackageName function and orphaned cf-require…
179f83f 
…ments.txt
@petebacondarwin petebacondarwin force-pushed the hoodmane/python-remove-cf-requirements branch from 5b538d0 to e2f546c Compare March 23, 2026 08:49
@petebacondarwin petebacondarwin force-pushed the hoodmane/python-remove-cf-requirements branch from e2f546c to 3c03370 Compare March 23, 2026 10:39
@petebacondarwin petebacondarwin merged commit 9a1cf29 into main Mar 23, 2026
48 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 23, 2026
@petebacondarwin petebacondarwin deleted the hoodmane/python-remove-cf-requirements branch March 23, 2026 11:11
@workers-devprod workers-devprod mentioned this pull request Mar 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@emily-shen emily-shen emily-shen left review comments

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoodmane @workers-devprod @petebacondarwin @emily-shen