Skip to content

wrangler: handle registry ports in digest checks#11892

Merged
petebacondarwin merged 3 commits intocloudflare:mainfrom
staticpayload:fix/wrangler-digest-registry-port
Mar 18, 2026
Merged

wrangler: handle registry ports in digest checks#11892
petebacondarwin merged 3 commits intocloudflare:mainfrom
staticpayload:fix/wrangler-digest-registry-port

Conversation

@staticpayload
Copy link
Copy Markdown
Contributor

@staticpayload staticpayload commented Jan 13, 2026 •
edited by petebacondarwin
Loading

Summary

  • strip tags without breaking registry ports when comparing RepoDigests
  • avoid unnecessary pushes for images like localhost:5000/app:tag
  • add test coverage for registry ports

Testing

  • pnpm -C /Users/staticpayload/workers-sdk -F wrangler test -- src/tests/cloudchamber/build.test.ts

    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows:
    • Additional testing not necessary because:

  • Public documentation

    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix
Open with Devin

@staticpayload staticpayload requested review from a team as code owners January 13, 2026 14:40
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 13, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: c36d1d2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin force-pushed the fix/wrangler-digest-registry-port branch from a80d5a0 to bace2cf Compare March 14, 2026 16:40
@workers-devprod
Copy link
Copy Markdown
Contributor

workers-devprod commented Mar 14, 2026 •
edited
Loading

Codeowners approval required for this PR:

  • ✅ @cloudflare/cloudchamber
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

devin-ai-integration[bot]
devin-ai-integration bot reviewed Mar 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Mar 18, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 18, 2026 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11892

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11892

miniflare

npm i https://pkg.pr.new/miniflare@11892

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11892

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11892

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11892

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11892

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11892

wrangler

npm i https://pkg.pr.new/wrangler@11892

commit: c36d1d2

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Mar 18, 2026
@petebacondarwin petebacondarwin merged commit 7c3c6c6 into cloudflare:main Mar 18, 2026
41 of 44 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Mar 18, 2026
@workers-devprod workers-devprod mentioned this pull request Mar 18, 2026
Merged
NuroDev pushed a commit that referenced this pull request Mar 18, 2026
@staticpayload @petebacondarwin @NuroDev
wrangler: handle registry ports in digest checks (#11892)
bf00b6a 
Co-authored-by: Pete Bacon Darwin <pbacondarwin@cloudflare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@gpanders gpanders gpanders approved these changes

@penalosa penalosa penalosa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@staticpayload @workers-devprod @petebacondarwin @gpanders @penalosa