Skip to content

chore(miniflare): remove unused dependencies#11849

Merged
petebacondarwin merged 2 commits into
cloudflare:mainfrom
43081j:miniflare-purge
Apr 19, 2026
Merged

chore(miniflare): remove unused dependencies#11849
petebacondarwin merged 2 commits into
cloudflare:mainfrom
43081j:miniflare-purge

Conversation

@43081j

@43081j 43081j commented Jan 9, 2026 •
edited by devin-ai-integration Bot
Loading

Copy link
Copy Markdown
Contributor

This removes a few unused devDependencies. The ones we still use
indirectly (e.g. TSESLint) are pulled in already by the standard ESLint
config.

  • Tests
    • Tests included/updated
    • Tests not necessary because: No functional changes
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: No functional changes
Open with Devin

@changeset-bot

changeset-bot Bot commented Jan 9, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e27f528

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey mentioned this pull request Jan 9, 2026
Open
vicb
vicb reviewed Jan 9, 2026
View reviewed changes
Comment thread packages/miniflare/package.json Outdated
@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Jan 10, 2026
@pkg-pr-new

pkg-pr-new Bot commented Jan 10, 2026 •
edited
Loading

Copy link
Copy Markdown
create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11849

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11849

miniflare

npm i https://pkg.pr.new/miniflare@11849

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11849

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11849

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11849

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11849

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11849

wrangler

npm i https://pkg.pr.new/wrangler@11849

commit: e27f528

@vicb vicb added ci:skip-pr-description-validation Skip validation of the required PR description format skip-changeset-review labels Jan 10, 2026
@43081j

43081j commented Feb 2, 2026

Copy link
Copy Markdown
Contributor Author

rebased onto latest main FYI 👍

devin-ai-integration[bot]
devin-ai-integration Bot reviewed Feb 2, 2026
View reviewed changes

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional flag.

Open in Devin Review

devin-ai-integration[bot]

This comment was marked as resolved.

Sign in to view

@penalosa

penalosa commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

/bonk can you rebase and fix the merge conflicts on this pr?

ask-bonk[bot]
ask-bonk Bot approved these changes Mar 20, 2026
View reviewed changes

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The removal of heap-js is correct — confirmed it has zero imports anywhere in the miniflare package (it's only used in workflows-shared).

Note for other reviewers: the Devin bot's February 13 review about mime being removed is a false positive on the current state of the PR. The author originally removed mime too, but reintroduced it in commit 7a59765 ("chore: reintroduce mime"). The final diff only removes heap-js.

Two minor observations (neither blocking):

  1. The changeset may be unnecessary — the project's own .changeset/README.md says changesets are not required for "changes only to devDependencies."
  2. The PR title/changeset description say "dependencies" (plural), but the final diff only removes one (heap-js). Consider squashing the commits before merge to keep a clean history, since the intermediate state (removing mime) was incorrect.

@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Mar 20, 2026
@ask-bonk

ask-bonk Bot commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Review submitted. Here's a summary:

Approved the PR. The change is correct — heap-js has zero imports in the miniflare package and is safe to remove.

Key findings:

  • The Devin bot's alarming review about mime being removed is a false positive — the author already fixed that in commit 7a59765 ("chore: reintroduce mime"). The final diff only removes heap-js.
  • Two minor non-blocking notes: the changeset is technically unnecessary per the repo's own guidelines (devDependency-only changes don't need one), and the title/description say "dependencies" (plural) when only one is removed in the final state.

github run

@43081j 43081j requested a review from workers-devprod as a code owner April 1, 2026 17:37
@43081j

43081j commented Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

FYI i have caught up from main again

@workers-devprod

workers-devprod commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • packages/miniflare/package.json: [@cloudflare/wrangler]
  • pnpm-lock.yaml: [@cloudflare/wrangler]

@workers-devprod

workers-devprod commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/wrangler
Show detailed file reviewers

workers-devprod
workers-devprod approved these changes Apr 19, 2026
View reviewed changes

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

43081j added 2 commits April 19, 2026 08:51
@43081j @petebacondarwin
chore(miniflare): remove unused dependencies
85e4c02 
This removes a few unused devDependencies. The ones we still use
indirectly (e.g. TSESLint) are pulled in already by the standard ESLint
config.
@43081j @petebacondarwin
chore: reintroduce mime
e27f528
@petebacondarwin petebacondarwin merged commit 266c418 into cloudflare:main Apr 19, 2026
58 of 59 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Apr 19, 2026
@workers-devprod workers-devprod mentioned this pull request Apr 19, 2026
Merged
@43081j 43081j deleted the miniflare-purge branch April 19, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vicb vicb vicb left review comments

@devin-ai-integration devin-ai-integration[bot] devin-ai-integration[bot] left review comments

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@workers-devprod workers-devprod workers-devprod approved these changes

@ask-bonk ask-bonk[bot] ask-bonk[bot] approved these changes

Assignees

No one assigned

Labels

ci:skip-pr-description-validation Skip validation of the required PR description format

Projects

workers-sdk
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@43081j @penalosa @workers-devprod @petebacondarwin @vicb