make Miniflare inspector proxy more resilient to selecting a free port#11202
Merged
petebacondarwin merged 9 commits intomainfrom Nov 11, 2025
Merged
make Miniflare inspector proxy more resilient to selecting a free port#11202petebacondarwin merged 9 commits intomainfrom
petebacondarwin merged 9 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: fb82aff The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
404df74 to
23f2d75
Compare
penalosa
reviewed
Nov 10, 2025
| try { | ||
| const port = await this.#getInspectorPortToUse(); | ||
| this.log.debug("Trying to listen on port: " + port); | ||
| server.listen(port, () => listening.resolve()); |
Contributor
There was a problem hiding this comment.
Does this throw synchronously?
Contributor
Author
There was a problem hiding this comment.
Urgh! I think you are right. If the port is taken then it calls the callback with an error parameter...
Contributor
Author
There was a problem hiding this comment.
Actually the callback never gets an arg, which is what led me to believe it would throw. Instead you have to add an error handler.
We have seen some test flakes when there are a lot of Miniflare instances running in parallel. This appears to be that there is a small chance that a port becomes unavailable between checking if it is free and using it.
23f2d75 to
f7c0089
Compare
penalosa
reviewed
Nov 10, 2025
packages/miniflare/src/plugins/core/inspector-proxy/inspector-proxy-controller.ts
Outdated
Show resolved
Hide resolved
ascorbic
approved these changes
Nov 11, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have seen some test flakes when there are a lot of Miniflare instances running in parallel. This appears to be that there is a small chance that a port becomes unavailable between checking if it is free and using it.