Workflow binding: remove dispose on void returning method#11084
Merged
Caio-Nogueira merged 1 commit intomainfrom Oct 31, 2025
Merged
Workflow binding: remove dispose on void returning method#11084Caio-Nogueira merged 1 commit intomainfrom
Caio-Nogueira merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 61fb933 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
b4c93c8 to
9891634
Compare
LuisDuarte1
approved these changes
Oct 27, 2025
9891634 to
c6c0f8b
Compare
dario-piotrowicz
approved these changes
Oct 30, 2025
c6c0f8b to
051b4e3
Compare
051b4e3 to
7c7180c
Compare
7c7180c to
61fb933
Compare
pombosilva
approved these changes
Oct 31, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes WOR-926.
This fix comes in sequence of #10919.
sendEventreturns void and therefore doesn't need disposal.Disposing here would make the dev output more noisy because users would see a runtime error which is a consequence of a failed disposer call.
sendEventis already covered with existing fixture tests. The coverage wasn't enough here because the hot path will still work (i.e.: event will be sent but the disposer will throw afterwards)