Skip to content

Add new attribute allowed_sender_addresses#10651

Merged
dario-piotrowicz merged 1 commit intomainfrom
email_allowed_sender_addresses
Sep 16, 2025
Merged

Add new attribute allowed_sender_addresses#10651
dario-piotrowicz merged 1 commit intomainfrom
email_allowed_sender_addresses

Conversation

@edevil
Copy link
Copy Markdown
Contributor

@edevil edevil commented Sep 15, 2025 •
edited by lrapoport-cf
Loading

Fixes EMAIL-1228.

Added new attribute called "allowed_sender_addresses" to send_email binding. This allows the binding to be restricted in the possible values for the sender of emails.

Approval: CR-1298791

@edevil edevil requested a review from a team as a code owner September 15, 2025 10:36
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Sep 15, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 48cfc69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
miniflare Minor
wrangler Minor
@cloudflare/pages-shared Patch
@cloudflare/vite-plugin Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Sep 15, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Sep 15, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10651

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10651

miniflare

npm i https://pkg.pr.new/miniflare@10651

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10651

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10651

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10651

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10651

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10651

wrangler

npm i https://pkg.pr.new/wrangler@10651

commit: 48cfc69

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 15, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main email_allowed_sender_addresses might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10651
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@dario-piotrowicz dario-piotrowicz mentioned this pull request Sep 16, 2025
Merged
1 task
dario-piotrowicz
dario-piotrowicz reviewed Sep 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me, I just left a few small suggestions 🙂

@edevil edevil force-pushed the email_allowed_sender_addresses branch 2 times, most recently from f149a3c to f062189 Compare September 16, 2025 17:14
@edevil
Add new attribute allowed_sender_addresses
48cfc69 
Added new attribute called "allowed_sender_addresses" to send_email
binding. This allows the binding to be restricted in the possible values
for the sender of emails.
@edevil edevil force-pushed the email_allowed_sender_addresses branch from f062189 to 48cfc69 Compare September 16, 2025 17:26
dario-piotrowicz
dario-piotrowicz approved these changes Sep 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! thanks for the updates 😄 🫶

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Sep 16, 2025
@dario-piotrowicz dario-piotrowicz merged commit 6caf938 into main Sep 16, 2025
54 of 59 checks passed
@dario-piotrowicz dario-piotrowicz deleted the email_allowed_sender_addresses branch September 16, 2025 20:47
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Sep 16, 2025
@workers-devprod workers-devprod mentioned this pull request Sep 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LuisDuarte1 LuisDuarte1 LuisDuarte1 approved these changes

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@edevil @LuisDuarte1 @dario-piotrowicz @workers-devprod