Skip to content

Bugfix: Update regex for valid branch names#10356

Merged
WillTaylorDev merged 1 commit intomainfrom
willtaylor/bugfix-longer-alias-names
Aug 13, 2025
Merged

Bugfix: Update regex for valid branch names#10356
WillTaylorDev merged 1 commit intomainfrom
willtaylor/bugfix-longer-alias-names

Conversation

@WillTaylorDev
Copy link
Copy Markdown
Contributor

Bugfix: updates regex to allow for longer branch names. This was previously failing the regex check, even though we later truncate the branch name if it's too long.

  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: n/a
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: V4 only

@WillTaylorDev WillTaylorDev requested a review from a team as a code owner August 13, 2025 15:36
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 13, 2025

🦋 Changeset detected

Latest commit: b6a6fe0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main willtaylor/bugfix-longer-alias-names might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10356
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/bugfix-longer-alias-names branch from a1dbbbe to 2265134 Compare August 13, 2025 15:38
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Aug 13, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10356

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10356

miniflare

npm i https://pkg.pr.new/miniflare@10356

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10356

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10356

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10356

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10356

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10356

wrangler

npm i https://pkg.pr.new/wrangler@10356

commit: b6a6fe0

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 13, 2025
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/bugfix-longer-alias-names branch from 4185f48 to b6a6fe0 Compare August 13, 2025 16:07
@WillTaylorDev WillTaylorDev merged commit 80e964c into main Aug 13, 2025
60 of 71 checks passed
@WillTaylorDev WillTaylorDev deleted the willtaylor/bugfix-longer-alias-names branch August 13, 2025 17:38
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants