Skip to content

add rollout_active_grace_period to container config#10315

Merged
emily-shen merged 8 commits intomainfrom
emily/rollout-grace-period
Aug 13, 2025
Merged

add rollout_active_grace_period to container config#10315
emily-shen merged 8 commits intomainfrom
emily/rollout-grace-period

Conversation

@emily-shen
Copy link
Copy Markdown
Contributor

@emily-shen emily-shen commented Aug 11, 2025

does what it says on the tin.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: working out a couple of other rollout related things before we document this fully
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: new feature

@emily-shen emily-shen requested a review from a team as a code owner August 11, 2025 11:14
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 11, 2025

🦋 Changeset detected

Latest commit: bb6dcbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Aug 11, 2025
@emily-shen emily-shen marked this pull request as draft August 11, 2025 11:15
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Aug 11, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10315

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10315

miniflare

npm i https://pkg.pr.new/miniflare@10315

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10315

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10315

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10315

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10315

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10315

wrangler

npm i https://pkg.pr.new/wrangler@10315

commit: bb6dcbd

@emily-shen emily-shen force-pushed the emily/rollout-grace-period branch from 4ae4d7a to c21552c Compare August 11, 2025 15:18
@emily-shen emily-shen marked this pull request as ready for review August 11, 2025 15:19
@emily-shen emily-shen force-pushed the emily/rollout-grace-period branch from c21552c to 604bdee Compare August 11, 2025 15:21
@github-actions
Copy link
Copy Markdown
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main emily/rollout-grace-period might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-10315
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@emily-shen emily-shen force-pushed the emily/rollout-grace-period branch from 561dc4b to cfa8b6b Compare August 11, 2025 16:29
@emily-shen emily-shen requested a review from penalosa August 11, 2025 16:51
Copy link
Copy Markdown
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor nits, but LGTM otherwise 🙏

@github-project-automation github-project-automation bot moved this from Untriaged to In Review in workers-sdk Aug 12, 2025
@emily-shen emily-shen force-pushed the emily/rollout-grace-period branch from 5c68605 to bb6dcbd Compare August 12, 2025 13:22
@github-project-automation github-project-automation bot moved this from In Review to Approved in workers-sdk Aug 13, 2025
@emily-shen emily-shen merged commit 0c04da9 into main Aug 13, 2025
54 of 59 checks passed
@emily-shen emily-shen deleted the emily/rollout-grace-period branch August 13, 2025 15:52
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants