add information about dashboard configuration differences on deploys#10314
add information about dashboard configuration differences on deploys#10314dario-piotrowicz merged 15 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: f87f4e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
There was a problem hiding this comment.
In order not to introduce unnecessary diffs in this PR (and making it much more complex to review) I would move the diff class in a separate followup PR
be1a383 to
9e6dc27
Compare
9e6dc27 to
abe4baa
Compare
| } | ||
|
|
||
| async function getWorkerConfig( | ||
| // TODO: move this to a shared location |
There was a problem hiding this comment.
Like for Diff I'd prefer not to do such refactoring as part of this PR as that would significantly (and with little gain) increase the diffs people would need to review here, if it's ok I'll do it as a followup
| } | ||
| : {}), | ||
| tail_consumers: serviceEnvMetadata.script.tail_consumers, | ||
| tail_consumers: serviceEnvMetadata.script.tail_consumers ?? undefined, |
There was a problem hiding this comment.
note: I've added this because otherwise tail_consumers would default to null which would not match with the undefined default value we have in wrangler
77a17ed to
c4c8ff6
Compare
Co-authored-by: Somhairle MacLeòid <smacleod@cloudflare.com>
Co-authored-by: Carmen Popoviciu <cpopoviciu@cloudflare.com>
Co-authored-by: Carmen Popoviciu <cpopoviciu@cloudflare.com>
c4c8ff6 to
f87f4e2
Compare
CarmenPopoviciu
left a comment
There was a problem hiding this comment.
amazing work Dario! 🚀
Initial step for #10235
Before:
After:
