cleanup some container images during local dev#10289
Merged
CarmenPopoviciu merged 4 commits intomainfrom Aug 14, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: b5b45a0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
ecf0807 to
5f0202c
Compare
| /** | ||
| * Get all repository tags for a given image | ||
| */ | ||
| export function getImageRepoTags( |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| export function getImageRepoTags( | |
| export function getRepoTagsForImage( |
| * Checks if the given image has any duplicate tags from previous dev sessions, | ||
| * and remove them if so. | ||
| */ | ||
| export function cleanupDuplicateImageTags( |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| export function cleanupDuplicateImageTags( | |
| export function removeDuplicateImageTags( |
flakey5
approved these changes
Aug 12, 2025
nikitassharma
approved these changes
Aug 12, 2025
36d48b9 to
4f3ea67
Compare
CarmenPopoviciu
approved these changes
Aug 14, 2025
4f3ea67 to
b5b45a0
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in a followup we should remove the uuid tag entirely and change it to a label. but that will require workerd changes so let's just do this for now