fix: re-push image even when only the dockerfile has changed#10248
fix: re-push image even when only the dockerfile has changed#10248petebacondarwin merged 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: b84b753 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
There was a problem hiding this comment.
argh - hoped github might've preserved the changes when i renamed this file. basically this is the same as the original, except i wanted to add some e2e tests for this image re-pushing behaviour since the docker command we use is experimental and could break under us. although i did simplify some of the dev test setup while i was there too.
abf5ec2 to
d69ecef
Compare
d69ecef to
b84b753
Compare
|
For posterity, I've ended up removing the e2e tests that check this behaviour because I can't get them to work in CI :( (regular unit tests still exist for this feature, the e2e tests worked locally too fwiw...) I think this is ok because I added the e2e tests because i thought it would be useful to test the actual behaviour of |
Fixes CC-5563