validate id in wrangler containers delete and also include container API calls in WRANGLER_LOG=debug#10232
Merged
emily-shen merged 7 commits intomainfrom Aug 7, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 9bb8a47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
gpanders
approved these changes
Aug 5, 2025
nikitassharma
approved these changes
Aug 5, 2025
flakey5
approved these changes
Aug 5, 2025
petebacondarwin
approved these changes
Aug 6, 2025
Contributor
petebacondarwin
left a comment
There was a problem hiding this comment.
a couple of nits
9800622 to
85ce640
Compare
Co-authored-by: Nikita Sharma <54369599+nikitassharma@users.noreply.github.com>
85ce640 to
9bb8a47
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CC-5810.
Previously we'd see
DELETE method not allowed for the oauth_token authentication schemewhen you try and do something likewrangler containers images delete <container-name>, because<container-name>didn't look like an ID to API gateway and it would get confused.Also, added container API calls to the output of
WRANGLER_LOG=debug, since I wanted to see that when i was debugging.