Skip to content

stop vitest pool workers breaking when containers are present #10162

Merged
emily-shen merged 5 commits intomainfrom
emily/vitest-containers-no-op
Aug 5, 2025
Merged

stop vitest pool workers breaking when containers are present #10162
emily-shen merged 5 commits intomainfrom
emily/vitest-containers-no-op

Conversation

@emily-shen
Copy link
Copy Markdown
Contributor

@emily-shen emily-shen commented Jul 31, 2025

This doesn't actually enable testing, but it stops vitest breaking entirely at least. also fixes enable_containers with the vite plugin.

todo: document enable_containers


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: new

@emily-shen emily-shen requested a review from a team as a code owner July 31, 2025 16:09
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jul 31, 2025

🦋 Changeset detected

Latest commit: fc15089

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emily-shen emily-shen force-pushed the emily/vitest-containers-no-op branch from 5f3d1fb to c00e251 Compare July 31, 2025 16:10
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jul 31, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Jul 31, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@10162

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@10162

miniflare

npm i https://pkg.pr.new/miniflare@10162

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@10162

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@10162

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@10162

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@10162

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@10162

wrangler

npm i https://pkg.pr.new/wrangler@10162

commit: fc15089

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Aug 4, 2025
@emily-shen emily-shen merged commit 5bd0a19 into main Aug 5, 2025
36 of 39 checks passed
@emily-shen emily-shen deleted the emily/vitest-containers-no-op branch August 5, 2025 09:30
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants