[miniflare] Fix mixed pipelines records (#12987)

petebacondarwin · web-flow · commit f8516dd47425 · 2026-03-21T16:04:01.000Z
diff --git a/.changeset/fix-mixed-pipelines.md b/.changeset/fix-mixed-pipelines.md
@@ -0,0 +1,7 @@
+---
+"miniflare": patch
+---
+
+fix: allow mixed `pipelines` records containing both string and object entries
+
+Previously, passing a `pipelines` config that mixed plain string values and object entries (e.g. `{ MY_PIPELINE: "pipeline-name", OTHER_PIPELINE: { pipeline: "...", remoteProxyConnectionString: ... } }`) would cause Miniflare to throw an error. Both forms are now accepted and normalised correctly.
diff --git a/packages/miniflare/src/plugins/pipelines/index.ts b/packages/miniflare/src/plugins/pipelines/index.ts
@@ -12,16 +12,18 @@ import {
 export const PipelineOptionsSchema = z.object({
 	pipelines: z
 		.union([
-			z.record(z.string()),
-			z.string().array(),
 			z.record(
-				z.object({
-					pipeline: z.string(),
-					remoteProxyConnectionString: z
-						.custom<RemoteProxyConnectionString>()
-						.optional(),
-				})
+				z.union([
+					z.string(),
+					z.object({
+						pipeline: z.string(),
+						remoteProxyConnectionString: z
+							.custom<RemoteProxyConnectionString>()
+							.optional(),
+					}),
+				])
 			),
+			z.string().array(),
 		])
 		.optional(),
 });
@@ -76,13 +78,13 @@ function bindingEntries(
 	namespaces?:
 		| Record<
 				string,
-				{
-					pipeline: string;
-					remoteProxyConnectionString?: RemoteProxyConnectionString;
-				}
+				| string
+				| {
+						pipeline: string;
+						remoteProxyConnectionString?: RemoteProxyConnectionString;
+				  }
 		  >
 		| string[]
-		| Record<string, string>
 ): [
 	bindingName: string,
 	{ id: string; remoteProxyConnectionString?: RemoteProxyConnectionString },
diff --git a/packages/miniflare/test/index.spec.ts b/packages/miniflare/test/index.spec.ts
@@ -172,6 +172,18 @@ test("Miniflare: accepts mixed d1Databases record", () => {
 	});
 	useDispose(mf);
 });
+
+test("Miniflare: accepts mixed pipelines record", () => {
+	const mf = new Miniflare({
+		modules: true,
+		script: "",
+		pipelines: {
+			LOCAL_PIPELINE: "local-pipeline",
+			REMOTE_PIPELINE: { pipeline: "remote-pipeline" },
+		},
+	});
+	useDispose(mf);
+});
 test("Miniflare: ready returns copy of entry URL", async ({ expect }) => {
 	const mf = new Miniflare({
 		port: 0,
