Add traceFlags to SpanContext type definition#6751
Conversation
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This adds the missing traceFlags property to the SpanContext type definition, matching the C++ implementation from #6576.
The type change itself is correct — readonly traceFlags?: number matches the C++ kj::Maybe<TraceFlags> exposed as js.num(flags) in trace-stream.c++.
However, one issue:
- Missing snapshot regeneration (medium severity): The
types/generated-snapshot/files need to be regenerated after changes totypes/defines/. CI validates that the snapshot matches the generated output. Runjust generate-typesand commit the updated snapshot files (types/generated-snapshot/latest/index.d.ts,types/generated-snapshot/latest/index.ts,types/generated-snapshot/experimental/index.d.ts,types/generated-snapshot/experimental/index.ts). See the recent Workflows PR for an example of this pattern (commit12cb5c8).
|
I'm Bonk, and I've done a quick review of your PR. The type definition change itself is correct — One actionable issue found:
Review posted to PR #6751. |
|
The generated output of |
Add trace flags to type. Missed in #6576