Skip to content

move v8 version to 14.8#6726

Merged
dcarney-cf merged 3 commits into
mainfrom
dcarney/v8-14.8
May 5, 2026
Merged

move v8 version to 14.8#6726
dcarney-cf merged 3 commits into
mainfrom
dcarney/v8-14.8

Conversation

@dcarney-cf

@dcarney-cf dcarney-cf commented May 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@dcarney-cf dcarney-cf requested review from a team as code owners May 5, 2026 07:39
@dcarney-cf dcarney-cf requested a review from penalosa May 5, 2026 07:39
fhanau
fhanau reviewed May 5, 2026
View reviewed changes
Comment thread patches/v8/0036-Fix-non-conforming-braced-init-list-in-value_or.patch
@fhanau

fhanau commented May 5, 2026

Copy link
Copy Markdown
Contributor

Actually looks like main already had 14.7 while this is trying to update from 14.6. I will re-review after this has been rebased

@dcarney-cf

dcarney-cf commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

@fhanau rebased on main. not sure how i missed that first time around

@codspeed-hq

codspeed-hq Bot commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will degrade performance by 8.65%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 71 untouched benchmarks
⏩ 129 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ simpleStringBody[Response] 19.4 µs 21.3 µs -8.65%

Comparing dcarney/v8-14.8 (4c753bf) with main (7d0a721)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@codecov-commenter

codecov-commenter commented May 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.59%. Comparing base (7d0a721) to head (4c753bf).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6726      +/-   ##
==========================================
- Coverage   66.61%   66.59%   -0.02%     
==========================================
  Files         402      402              
  Lines      115803   115803              
  Branches    19395    19395              
==========================================
- Hits        77139    77116      -23     
- Misses      27094    27121      +27     
+ Partials    11570    11566       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcarney-cf dcarney-cf enabled auto-merge May 5, 2026 18:01
@dcarney-cf dcarney-cf merged commit b017f4e into main May 5, 2026
43 of 46 checks passed
@dcarney-cf dcarney-cf deleted the dcarney/v8-14.8 branch May 5, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhanau fhanau fhanau approved these changes

@penalosa penalosa Awaiting requested review from penalosa penalosa was automatically assigned from cloudflare/wrangler

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dcarney-cf @fhanau @codecov-commenter