Skip to content

Delete code: The Fiddle is no more.#6722

Merged
kentonv merged 1 commit into
mainfrom
kenton/nuke-fiddle
May 4, 2026
Merged

Delete code: The Fiddle is no more.#6722
kentonv merged 1 commit into
mainfrom
kenton/nuke-fiddle

Conversation

@kentonv

@kentonv kentonv commented May 4, 2026

Copy link
Copy Markdown
Member

No description provided.

@kentonv kentonv requested review from a team as code owners May 4, 2026 19:14
@ask-bonk

ask-bonk Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

There's a minor style issue (double blank line at 191+193 after the JSG_REQUIRE removal), but clang-format handles whitespace in this repo, so that's not actionable.

This PR is a clean dead-code removal. It removes the isFiddle() plumbing from ThreadContext and IoContext, removes fiddle-specific code paths in the Cache API, Blob/FormData (the kj::Array<kj::byte> variant and parseWithoutLock), and sockets, and updates stale comments. All references to fiddle are fully eliminated from the source tree. The OneOf types in Blob are correctly narrowed. No behavioral changes for production code, no backward compatibility concerns, no security issues.

LGTM

github run

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@kentonv kentonv force-pushed the kenton/nuke-fiddle branch from 9e80ffb to fcf4202 Compare May 4, 2026 19:25
Comment thread src/workerd/api/blob.c++
@kentonv kentonv force-pushed the kenton/nuke-fiddle branch from fcf4202 to 62855d8 Compare May 4, 2026 20:04
@kentonv kentonv requested a review from a team as a code owner May 4, 2026 20:04
@kentonv kentonv requested a review from emily-shen May 4, 2026 20:04
@kentonv kentonv force-pushed the kenton/nuke-fiddle branch from 62855d8 to ce467b6 Compare May 4, 2026 20:25
@kentonv kentonv merged commit ae0ca7a into main May 4, 2026
52 of 59 checks passed
@kentonv kentonv deleted the kenton/nuke-fiddle branch May 4, 2026 21:38
declare class Blob {
constructor(
type?: ((ArrayBuffer | ArrayBufferView) | string | Blob)[],
bits?: ((ArrayBuffer | ArrayBufferView) | string | Blob)[],

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this changed names but the new name seems more correct (it's the actual name) so I accepted it. Also the name is irrelevant to actual type checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants