The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

I'm Bonk, and I've done a quick review of your PR.

This PR adds WorkflowInstanceRestartOptions with a from parameter to allow restarting a workflow from a specific step. Type declarations, generated snapshots, tests, and mock are all updated — but the actual runtime implementation was not changed.

Issues

1. [HIGH] restart() implementation not updated — The InstanceImpl.restart() method in src/cloudflare/internal/workflows-api.ts (lines 70-74) ignores the options argument entirely. The from field is never serialized into the request body sent to the backend. The current implementation sends only { id: this.id } regardless of what's passed in.

   The tests should catch this — testRestartFromStepNameOnly asserts body.from equals { name: 'fetch data' }, but the implementation never sends from, so these tests would fail.

   Suggested fix in src/cloudflare/internal/workflows-api.ts:

   - async restart(): Promise<void> {
   -   await callFetcher(this.fetcher, '/restart', {
   -     id: this.id,
   -   });
   - }
   + async restart(options?: WorkflowInstanceRestartOptions): Promise<void> {
   +   await callFetcher(this.fetcher, '/restart', {
   +     id: this.id,
   +     ...options,
   +   });
   + }

2. [LOW] Mock uses module-level mutable state — lastRestartBody in workflows-mock.js is module-level mutable state shared across all test cases. If test ordering changes or tests run concurrently, this could produce flaky assertions. Not a blocker, just worth noting.

This review was generated by an AI assistant and may contain inaccuracies.

I'm Bonk, and I've done a quick review of your PR.

The key finding is high severity: the actual implementation in src/cloudflare/internal/workflows-api.ts was not updated. The restart() method (lines 70-74) still ignores any arguments — the from field from WorkflowInstanceRestartOptions is never serialized into the request body. The type declarations and tests all expect it, but the runtime code silently drops it. The new tests (testRestartFromStepNameOnly, testRestartFromStepAllOptions) should fail because of this, since the mock will never receive the from field.

A suggested fix was posted as a PR comment.

github run

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks¹

_{Comparing osilva/restart-from-step (12cb5c8) with main (ae4004e)}