Skip to content

[build] Update Rust, workerd-cxx#6646

Merged
fhanau merged 1 commit into
mainfrom
felix/042326-update-rust
Apr 23, 2026
Merged

[build] Update Rust, workerd-cxx#6646
fhanau merged 1 commit into
mainfrom
felix/042326-update-rust

Conversation

@fhanau

@fhanau fhanau commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Includes cloudflare/workerd-cxx#97 and Rust 1.95.0

@fhanau fhanau requested review from a team as code owners April 23, 2026 17:03
ask-bonk[bot]
ask-bonk Bot reviewed Apr 23, 2026
View reviewed changes

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Bonk, and I've done a quick review of your PR.

This PR updates Rust from 1.91.0 to 1.95.0 (LLVM 21 → 22), bumps the nightly toolchain, updates workerd-cxx to a commit from PR #97, and bumps SWC crates to new major versions.

Issues (ranked by severity):

  1. Medium — workerd-cxx points at an unmerged PR commit. The workerd-cxx dependency references commit 88b92c4 from cloudflare/workerd-cxx#97, which is still OPEN. If that PR is abandoned, force-pushed, or the branch is deleted, the tarball URL could become stale. The TODO comment acknowledges this, but make sure workerd-cxx#97 is merged before (or shortly after) this lands, and follow up to update the reference to a main-branch commit.

  2. Low — integrity vs sha256 format inconsistency. The workerd-cxx entry switched from the sha256 hex format to the integrity SRI format. Every other http.archive entry in deps.MODULE.bazel uses sha256. Both work, but it's a style inconsistency in what is otherwise a consistent file.

Comment thread build/deps/gen/deps.MODULE.bazel Outdated
Comment thread build/deps/gen/deps.MODULE.bazel Outdated
@ask-bonk

ask-bonk Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

This PR updates Rust from 1.91.0 to 1.95.0 (LLVM 21 → 22), bumps the nightly toolchain, updates workerd-cxx to a commit from PR #97, and bumps SWC crates to new major versions.

I posted a batch review with two findings:

  1. Medium — The workerd-cxx dependency references commit 88b92c4 from [build] Update deps, stop vendoring crates workerd-cxx#97, which is still OPEN. The TODO comment acknowledges this needs follow-up, but flagged it to ensure it doesn't get lost.

  2. Low — The hash format switched from sha256 (hex) to integrity (SRI) while all other entries in the file use sha256. Minor style inconsistency.

github run

@fhanau fhanau force-pushed the felix/042326-update-rust branch from 3fcf08b to 9453030 Compare April 23, 2026 17:28
@codspeed-hq

codspeed-hq Bot commented Apr 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks1

Comparing felix/042326-update-rust (a29b933) with main (b322726)2

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (4028835) during the generation of this report, so b322726 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@fhanau fhanau force-pushed the felix/042326-update-rust branch from 9453030 to a29b933 Compare April 23, 2026 20:17
@fhanau fhanau merged commit 8af12c7 into main Apr 23, 2026
21 of 22 checks passed
@fhanau fhanau deleted the felix/042326-update-rust branch April 23, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ask-bonk ask-bonk[bot] ask-bonk[bot] left review comments

@npaun npaun npaun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fhanau @npaun