Skip to content

Support 'primary-only' routing mode on workerd#6629

Merged
jtolio merged 1 commit into
mainfrom
jolio/allow-primary-routing
Apr 23, 2026
Merged

Support 'primary-only' routing mode on workerd#6629
jtolio merged 1 commit into
mainfrom
jolio/allow-primary-routing

Conversation

@jtolio

@jtolio jtolio commented Apr 21, 2026

Copy link
Copy Markdown
Member

It's primary only anyway, so we can allow it.

@jtolio jtolio requested review from a team as code owners April 21, 2026 17:35
@jtolio jtolio enabled auto-merge (rebase) April 21, 2026 17:35
@ask-bonk

ask-bonk Bot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

UnknownError: ProviderInitError

github run

@ask-bonk

ask-bonk Bot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

@jtolio Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@jtolio jtolio requested a review from lambrospetrou April 21, 2026 17:38
@jtolio jtolio force-pushed the jolio/allow-primary-routing branch from bd70e1c to 13ab8ef Compare April 21, 2026 17:43
Comment thread src/workerd/server/server.c++ Outdated
@codspeed-hq

codspeed-hq Bot commented Apr 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks1


Comparing jolio/allow-primary-routing (9769b1d) with main (4028835)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@justin-mp justin-mp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please rebase on top of main instead of merging main.

Comment thread src/workerd/server/server.c++ Outdated
@jtolio

jtolio commented Apr 22, 2026

Copy link
Copy Markdown
Member Author

Also, please rebase on top of main instead of merging main.

this was the same circumstances as #6605 (comment). will fix.

@jtolio jtolio force-pushed the jolio/allow-primary-routing branch 2 times, most recently from 2cb2823 to 1c20366 Compare April 22, 2026 19:57
It's primary only anyway, so we can allow it.
@jtolio jtolio force-pushed the jolio/allow-primary-routing branch from 1c20366 to 9769b1d Compare April 23, 2026 20:01
@jtolio

jtolio commented Apr 23, 2026

Copy link
Copy Markdown
Member Author

trivial rebase ^

@jtolio jtolio merged commit a35dc68 into main Apr 23, 2026
21 checks passed
@jtolio jtolio deleted the jolio/allow-primary-routing branch April 23, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants