[build] unpin rules_rust#6620
Conversation
|
UnknownError: ProviderInitError |
|
@mikea Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
52e715f to
cee9f40
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
cee9f40 to
dcc5152
Compare
|
The generated output of |
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR unpins rules_rust from a specific commit (cb9d412) and moves to the BCR release (0.69.0), and adds a "rust" tag to all Rust test targets so coverage runs can exclude them.
Issues found (1):
- [MED]
tagsinwd_rust_binaryis a bare string, not a list, and drops caller-supplied tags.
This review was generated by an AI assistant and may contain inaccuracies.
|
Review posted successfully on PR #6620. Here's a summary: One issue found:
The rest of the PR -- unpinning |
82183d9 to
7fdcd3b
Compare
bazelbuild/rules_rust#3812 will probably never land We can't afford to be stuck forever.
7fdcd3b to
229e052
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6620 +/- ##
==========================================
- Coverage 70.90% 66.52% -4.39%
==========================================
Files 438 405 -33
Lines 123833 115815 -8018
Branches 19486 19381 -105
==========================================
- Hits 87803 77045 -10758
- Misses 24483 27197 +2714
- Partials 11547 11573 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bazelbuild/rules_rust#3812 will probably never land
We can't afford to be stuck forever.