Skip to content

[build] unpin rules_rust#6620

Merged
mikea merged 1 commit into
mainfrom
maizatskyi/2026-04-20-rust-rules
Apr 20, 2026
Merged

[build] unpin rules_rust#6620
mikea merged 1 commit into
mainfrom
maizatskyi/2026-04-20-rust-rules

Conversation

@mikea

@mikea mikea commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

bazelbuild/rules_rust#3812 will probably never land

We can't afford to be stuck forever.

@mikea mikea requested review from fhanau and npaun April 20, 2026 20:06
@mikea mikea requested review from a team as code owners April 20, 2026 20:06
@ask-bonk

ask-bonk Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

UnknownError: ProviderInitError

github run

@ask-bonk

ask-bonk Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

@mikea Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@mikea mikea force-pushed the maizatskyi/2026-04-20-rust-rules branch from 52e715f to cee9f40 Compare April 20, 2026 20:21
@codspeed-hq

codspeed-hq Bot commented Apr 20, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 129 skipped benchmarks1


Comparing maizatskyi/2026-04-20-rust-rules (229e052) with main (688f691)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@mikea mikea force-pushed the maizatskyi/2026-04-20-rust-rules branch from cee9f40 to dcc5152 Compare April 20, 2026 20:53
@github-actions

github-actions Bot commented Apr 20, 2026

Copy link
Copy Markdown

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Bonk, and I've done a quick review of your PR.

This PR unpins rules_rust from a specific commit (cb9d412) and moves to the BCR release (0.69.0), and adds a "rust" tag to all Rust test targets so coverage runs can exclude them.

Issues found (1):

  1. [MED] tags in wd_rust_binary is a bare string, not a list, and drops caller-supplied tags.

This review was generated by an AI assistant and may contain inaccuracies.

Comment thread build/wd_rust_binary.bzl Outdated
@ask-bonk

ask-bonk Bot commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Review posted successfully on PR #6620. Here's a summary:

One issue found:

  1. [MED] In build/wd_rust_binary.bzl:78, tags = "rust" is a bare string instead of a list, and it discards the caller-supplied tags parameter. The other two macros (wd_rust_crate, wd_rust_proc_macro) correctly use test_tags + ["rust"]. I posted a suggestion to change it to tags = tags + ["rust"] for consistency.

The rest of the PR -- unpinning rules_rust to 0.69.0 from BCR, removing the archive_override, adding the -rust tag filter to coverage config -- looks correct and straightforward.

github run

@mikea mikea force-pushed the maizatskyi/2026-04-20-rust-rules branch 2 times, most recently from 82183d9 to 7fdcd3b Compare April 20, 2026 21:14
bazelbuild/rules_rust#3812 will probably never land

We can't afford to be stuck forever.
@mikea mikea force-pushed the maizatskyi/2026-04-20-rust-rules branch from 7fdcd3b to 229e052 Compare April 20, 2026 22:00
@mikea mikea requested a review from a team as a code owner April 20, 2026 22:00
@mikea mikea requested a review from edmundhung April 20, 2026 22:00
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.52%. Comparing base (2e63ac5) to head (229e052).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6620      +/-   ##
==========================================
- Coverage   70.90%   66.52%   -4.39%     
==========================================
  Files         438      405      -33     
  Lines      123833   115815    -8018     
  Branches    19486    19381     -105     
==========================================
- Hits        87803    77045   -10758     
- Misses      24483    27197    +2714     
- Partials    11547    11573      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mikea mikea merged commit 5ce8b89 into main Apr 20, 2026
22 checks passed
@mikea mikea deleted the maizatskyi/2026-04-20-rust-rules branch April 20, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants