Add Node.js constants#6568
Conversation
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR adds a large set of Node.js compatibility constants across multiple modules (async_hooks, process, sqlite, zlib, http2, events, _http_common, constants). Overall the approach is correct — exposing stub constants for compat — but I found a few accuracy issues against current Node.js main.
- [MED]
process.features.uvistruebut workerd does not use libuv - [MED]
process.versionsincludescjs_module_lexerwhich is not aprocess.versionskey in Node.js - [LOW]
process.versionsis missingngtcp2andnghttp3which are in Node.jsNODE_VERSIONS_KEYS_BASE - [LOW]
asyncWrapProvidersincludesQUIC_PACKET: 68which does not exist in current Node.jsmainasync_wrap.h
This review was generated by an AI code review assistant and may contain inaccuracies.
|
I'm Bonk, and I've done a quick review of your PR. This PR adds Node.js compatibility constants across multiple modules (async_hooks, process, sqlite, zlib, http2, events, _http_common, constants). I verified the constant values against current Node.js
All findings have been posted as inline review comments on PR #6568 with suggestions where applicable. |
Merging this PR will improve performance by 14.07%
Performance Changes
Comparing Footnotes
|
1511e18 to
5f18390
Compare
No description provided.