Skip to content

Remove explicit unknown type parameter from MessageBatch in queue…#6520

Merged
tewaro merged 1 commit into
mainfrom
tgarg/MQ-990-queue-binding-accepts-generic-to-define-message-type
Apr 9, 2026
Merged

Remove explicit unknown type parameter from MessageBatch in queue…#6520
tewaro merged 1 commit into
mainfrom
tgarg/MQ-990-queue-binding-accepts-generic-to-define-message-type

Conversation

@tewaro

@tewaro tewaro commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

… handler signatures

@tewaro tewaro requested review from a team as code owners April 8, 2026 06:42
@tewaro tewaro requested a review from petebacondarwin April 8, 2026 06:42
@ask-bonk

ask-bonk Bot commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

This is a clean, straightforward change. The MessageBatch interface already declares its type parameter with a default of unknown (MessageBatch<Body = unknown>), so removing the explicit <unknown> from the usage site MessageBatch<unknown>MessageBatch is a no-op in terms of TypeScript semantics. The resulting type is identical. This is a harmless cleanup that makes the handler signature less noisy and lets users provide their own type argument more naturally when extending the interface.

No logic bugs, no security issues, no backward compatibility concerns, no missing compat flags.

LGTM

github run

@tewaro tewaro enabled auto-merge April 8, 2026 07:23
@tewaro tewaro merged commit 3bc057f into main Apr 9, 2026
25 of 26 checks passed
@tewaro tewaro deleted the tgarg/MQ-990-queue-binding-accepts-generic-to-define-message-type branch April 9, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants