Skip to content

Update v8 to 14.7#6509

Merged
vickykont merged 3 commits into
mainfrom
vasiliki/v8-14.7
Apr 9, 2026
Merged

Update v8 to 14.7#6509
vickykont merged 3 commits into
mainfrom
vasiliki/v8-14.7

Conversation

@vickykont

@vickykont vickykont commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Patches that conflicted were:

  • 0022-Port-V8_USE_ZLIB-support.patch: trivial
  • 0030-Expose-AdjustAmountOfExternalAllocatedMemoryImpl-as-.patch: trivial
  • 0033-Return-false-on-Object.hasOwnProperty-with-intercept.patch: partially upstreamed

@vickykont vickykont requested review from a team as code owners April 7, 2026 14:06
@github-actions

github-actions Bot commented Apr 7, 2026 •
edited
Loading

Copy link
Copy Markdown

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@ask-bonk

ask-bonk Bot commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

The response is base64 encoded. Let me decode the relevant parts.

github run

fhanau
fhanau approved these changes Apr 7, 2026
View reviewed changes

@fhanau fhanau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have context on patch 33 but LGTM otherwise.

@jasnell

jasnell commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

PR will need to be rebased on main for CI to run successfully.

jasnell
jasnell reviewed Apr 7, 2026
View reviewed changes
Comment thread patches/v8/0033-Return-false-on-Object.hasOwnProperty-with-intercept.patch
@vickykont

vickykont commented Apr 7, 2026

Copy link
Copy Markdown
Contributor Author

Last push was an automatic rebase on top of main.

@fhanau fhanau mentioned this pull request Apr 8, 2026
Closed
@codspeed-hq

codspeed-hq Bot commented Apr 8, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 28.28%

⚡ 1 improved benchmark
❌ 2 regressed benchmarks
✅ 67 untouched benchmarks
⏩ 129 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ simpleStringBody[Response] 19.5 µs 27.2 µs -28.28%
⚡ Encode_ASCII_32[TextEncoder][0/0/32] 3.1 ms 2.7 ms +13.18%
❌ Encode_ASCII_256[TextEncoder][0/0/256] 2.7 ms 3.1 ms -14.33%

Comparing vasiliki/v8-14.7 (1c7dbd7) with main (5138dd5)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@vickykont vickykont merged commit 32a5758 into main Apr 9, 2026
22 checks passed
@vickykont vickykont deleted the vasiliki/v8-14.7 branch April 9, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell left review comments

@fhanau fhanau fhanau approved these changes

@dcarney-cf dcarney-cf dcarney-cf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vickykont @jasnell @fhanau @dcarney-cf