abortWrite takes kj::Exception&&. The code passes kj::cp(e) which produces a temporary kj::Exception (an rvalue), which binds to &&. This is correct.

Now let me check: connection.abortWrite(kj::cp(e)) — connection is the raw kj::AsyncIoStream&. After neutering the wrapper, calling abortWrite/abortRead on the underlying stream is intentional to force-close the connection. The kj::cp(e) on line 274 copies the exception before moving it to neuter() on line 273, so the ordering is fine.

Wait, let me re-read: line 273 uses kj::cp(e) and line 274 also uses kj::cp(e). Then e itself is still valid. This is fine since both kj::cp() calls just copy, they don't move from e.

The implementation follows the same pattern as RevocableWebSocket and looks correct. The change replaces a KJ_UNIMPLEMENTED with actual functionality.

LGTM

github run

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

Rebased the PR to fix CI