Skip to content

Fixup a couple small new module registry nits#6492

Merged
jasnell merged 1 commit intomainfrom
jasnell/minor-nmr-nits
Apr 3, 2026
Merged

Fixup a couple small new module registry nits#6492
jasnell merged 1 commit intomainfrom
jasnell/minor-nmr-nits

Conversation

@jasnell
Copy link
Copy Markdown
Collaborator

@jasnell jasnell commented Apr 3, 2026

No description provided.

@jasnell jasnell requested review from a team as code owners April 3, 2026 01:00
@jasnell jasnell requested review from guybedford and npaun April 3, 2026 01:00
@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk bot commented Apr 3, 2026

Both isEval() and isWasm() are defined in the .c++ file (not in the header), so the inline keyword on their declarations in the header was indeed redundant and misleading. The other similar accessors in the same class (isEsm(), isMain()) already don't have inline, and the ones that do retain inline (type(), contentType()) are defined inline in the header body. This is a clean, correct consistency fix.

LGTM

github run

@codspeed-hq

This comment was marked as outdated.

@jasnell jasnell enabled auto-merge April 3, 2026 03:30
@jasnell jasnell merged commit dcc9488 into main Apr 3, 2026
25 of 26 checks passed
@jasnell jasnell deleted the jasnell/minor-nmr-nits branch April 3, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants