Skip to content

Improvements to MimeType#6487

Merged
jasnell merged 1 commit intomainfrom
jasnell/cleanup-mimetype
Apr 2, 2026
Merged

Improvements to MimeType#6487
jasnell merged 1 commit intomainfrom
jasnell/cleanup-mimetype

Conversation

@jasnell
Copy link
Copy Markdown
Collaborator

@jasnell jasnell commented Apr 2, 2026

Multiple MimeType cleanups/improvements. Better handling of escapes, some simplifications and perf improvements.

@jasnell jasnell requested review from a team as code owners April 2, 2026 19:12
ask-bonk[bot]

This comment was marked as resolved.

Sign in to view

@ask-bonk

This comment was marked as resolved.

Sign in to view
@jasnell jasnell requested review from guybedford and npaun April 2, 2026 19:21
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 2, 2026

Merging this PR will improve performance by 14.84%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 69 untouched benchmarks
⏩ 129 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ Encode_ASCII_32[TextEncoder][0/0/32] 3 ms 2.6 ms +14.84%

Comparing jasnell/cleanup-mimetype (0f5493d) with main (862a428)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 90.22801% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.84%. Comparing base (55fbbf3) to head (0f5493d).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/workerd/util/mimetype-test.c++ 90.00% 0 Missing and 26 partials ⚠️
src/workerd/api/util-test.c++ 25.00% 2 Missing and 1 partial ⚠️
src/workerd/util/mimetype.c++ 97.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6487      +/-   ##
==========================================
- Coverage   70.85%   70.84%   -0.02%     
==========================================
  Files         434      434              
  Lines      122125   122180      +55     
  Branches    19137    19167      +30     
==========================================
+ Hits        86536    86559      +23     
- Misses      24280    24286       +6     
- Partials    11309    11335      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell jasnell merged commit b7a52bb into main Apr 2, 2026
27 checks passed
@jasnell jasnell deleted the jasnell/cleanup-mimetype branch April 2, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ask-bonk ask-bonk[bot] ask-bonk[bot] left review comments

@guybedford guybedford Awaiting requested review from guybedford

@npaun npaun Awaiting requested review from npaun

+1 more reviewer

@anonrig anonrig anonrig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasnell @codecov-commenter @anonrig